Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: public/platform/WebLayerPositionConstraint.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix style errors and remaining layout tests. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef WebLayerPositionConstraint_h 26 #ifndef WebLayerPositionConstraint_h
27 #define WebLayerPositionConstraint_h 27 #define WebLayerPositionConstraint_h
28 28
29 #include "public/platform/WebRect.h"
30
29 namespace blink { 31 namespace blink {
30 32
31 struct WebLayerPositionConstraint { 33 struct WebLayerPositionConstraint {
32 bool isFixedPosition : 1; 34 bool isFixedPosition : 1;
33 bool isFixedToRightEdge : 1; 35 bool isFixedToRightEdge : 1;
34 bool isFixedToBottomEdge : 1; 36 bool isFixedToBottomEdge : 1;
35 37
36 WebLayerPositionConstraint() 38 WebLayerPositionConstraint()
37 : isFixedPosition(false) 39 : isFixedPosition(false)
38 , isFixedToRightEdge(false) 40 , isFixedToRightEdge(false)
39 , isFixedToBottomEdge(false) 41 , isFixedToBottomEdge(false)
40 { 42 {
41 } 43 }
42 44
43 static WebLayerPositionConstraint fixedPosition(bool fixedToRightEdge, bool fixedToBottomEdge) 45 static WebLayerPositionConstraint fixedPosition(bool fixedToRightEdge, bool fixedToBottomEdge)
44 { 46 {
45 WebLayerPositionConstraint constraint; 47 WebLayerPositionConstraint constraint;
46 constraint.isFixedPosition = true; 48 constraint.isFixedPosition = true;
47 constraint.isFixedToRightEdge = fixedToRightEdge; 49 constraint.isFixedToRightEdge = fixedToRightEdge;
48 constraint.isFixedToBottomEdge = fixedToBottomEdge; 50 constraint.isFixedToBottomEdge = fixedToBottomEdge;
49 return constraint; 51 return constraint;
50 } 52 }
51 }; 53 };
52 54
55 // TODO(flackr): Combine with the fixed position constraint above?
enne (OOO) 2015/09/17 16:57:40 Yeah, I think this should probably be merged with
56 struct WebLayerStickyPositionConstraint {
57 bool isSticky : 1;
58 bool isAnchoredLeft : 1;
59 bool isAnchoredRight : 1;
60 bool isAnchoredTop : 1;
61 bool isAnchoredBottom : 1;
62
63 float leftOffset;
64 float rightOffset;
65 float topOffset;
66 float bottomOffset;
67
68 WebRect absoluteStickyBoxRect;
enne (OOO) 2015/09/17 16:57:40 Are these values redundant with WebLayer's bounds
flackr 2015/09/22 22:25:32 I don't think so, but please correct me if I am mi
69 WebRect absoluteContainingBlockRect;
70
71 // TODO(flackr): Add fancy ctor and static creation sugar.
72 WebLayerStickyPositionConstraint()
73 : isSticky(false)
74 , isAnchoredLeft(false)
75 , isAnchoredRight(false)
76 , isAnchoredTop(false)
77 , isAnchoredBottom(false)
78 , leftOffset(0.f)
79 , rightOffset(0.f)
80 , topOffset(0.f)
81 , bottomOffset(0.f)
82 {
83 }
84 };
85
53 } // namespace blink 86 } // namespace blink
54 87
55 #endif // WebLayerPositionConstraint_h 88 #endif // WebLayerPositionConstraint_h
OLDNEW
« Source/core/paint/DeprecatedPaintLayer.cpp ('K') | « public/platform/WebLayer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698