Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Store ancestor overflow layer on PaintLayer to compute before other dependent compositing inputs. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections. 192 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections.
193 if (style.hasAutoZIndex() && ((element && element->document().documentElemen t() == element) 193 if (style.hasAutoZIndex() && ((element && element->document().documentElemen t() == element)
194 || style.hasOpacity() 194 || style.hasOpacity()
195 || style.hasTransformRelatedProperty() 195 || style.hasTransformRelatedProperty()
196 || style.hasMask() 196 || style.hasMask()
197 || style.clipPath() 197 || style.clipPath()
198 || style.boxReflect() 198 || style.boxReflect()
199 || style.hasFilter() 199 || style.hasFilter()
200 || style.hasBlendMode() 200 || style.hasBlendMode()
201 || style.hasIsolation() 201 || style.hasIsolation()
202 || style.position() == FixedPosition 202 || style.hasViewportConstrainedPosition()
203 || isInTopLayer(element, style) 203 || isInTopLayer(element, style)
204 || hasWillChangeThatCreatesStackingContext(style) 204 || hasWillChangeThatCreatesStackingContext(style)
205 || style.containsPaint())) 205 || style.containsPaint()))
206 style.setZIndex(0); 206 style.setZIndex(0);
207 207
208 if (doesNotInheritTextDecoration(style, element)) 208 if (doesNotInheritTextDecoration(style, element))
209 style.clearAppliedTextDecorations(); 209 style.clearAppliedTextDecorations();
210 210
211 style.applyTextDecorations(); 211 style.applyTextDecorations();
212 212
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 style.setDisplay(INLINE_BLOCK); 409 style.setDisplay(INLINE_BLOCK);
410 410
411 // After performing the display mutation, check table rows. We do not honor position: relative table rows or cells. 411 // After performing the display mutation, check table rows. We do not honor position: relative table rows or cells.
412 // This has been established for position: relative in CSS2.1 (and caused a crash in containingBlock() 412 // This has been established for position: relative in CSS2.1 (and caused a crash in containingBlock()
413 // on some sites). 413 // on some sites).
414 if ((style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW_G ROUP 414 if ((style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW_G ROUP
415 || style.display() == TABLE_FOOTER_GROUP || style.display() == TABLE_ROW ) 415 || style.display() == TABLE_FOOTER_GROUP || style.display() == TABLE_ROW )
416 && style.position() == RelativePosition) 416 && style.position() == RelativePosition)
417 style.setPosition(StaticPosition); 417 style.setPosition(StaticPosition);
418 418
419 // Cannot support position: sticky for table columns and column groups becau se current code is only doing
420 // background painting through columns / column groups
421 if ((style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_COLUM N)
422 && style.position() == StickyPosition)
423 style.setPosition(StaticPosition);
424
419 // writing-mode does not apply to table row groups, table column groups, tab le rows, and table columns. 425 // writing-mode does not apply to table row groups, table column groups, tab le rows, and table columns.
420 // FIXME: Table cells should be allowed to be perpendicular or flipped with respect to the table, though. 426 // FIXME: Table cells should be allowed to be perpendicular or flipped with respect to the table, though.
421 if (style.display() == TABLE_COLUMN || style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_FOOTER_GROUP 427 if (style.display() == TABLE_COLUMN || style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_FOOTER_GROUP
422 || style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW || style.display() == TABLE_ROW_GROUP 428 || style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW || style.display() == TABLE_ROW_GROUP
423 || style.display() == TABLE_CELL) 429 || style.display() == TABLE_CELL)
424 style.setWritingMode(parentStyle.getWritingMode()); 430 style.setWritingMode(parentStyle.getWritingMode());
425 431
426 // FIXME: Since we don't support block-flow on flexible boxes yet, disallow setting 432 // FIXME: Since we don't support block-flow on flexible boxes yet, disallow setting
427 // of block-flow to anything other than TopToBottomWritingMode. 433 // of block-flow to anything other than TopToBottomWritingMode.
428 // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support. 434 // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support.
429 if (style.getWritingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX)) 435 if (style.getWritingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX))
430 style.setWritingMode(TopToBottomWritingMode); 436 style.setWritingMode(TopToBottomWritingMode);
431 437
432 if (parentStyle.isDisplayFlexibleOrGridBox()) { 438 if (parentStyle.isDisplayFlexibleOrGridBox()) {
433 style.setFloating(NoFloat); 439 style.setFloating(NoFloat);
434 style.setDisplay(equivalentBlockDisplay(style.display())); 440 style.setDisplay(equivalentBlockDisplay(style.display()));
435 441
436 // We want to count vertical percentage paddings/margins on flex items b ecause our current 442 // We want to count vertical percentage paddings/margins on flex items b ecause our current
437 // behavior is different from the spec and we want to gather compatibili ty data. 443 // behavior is different from the spec and we want to gather compatibili ty data.
438 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t()) 444 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t())
439 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical); 445 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical);
440 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( )) 446 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( ))
441 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal); 447 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal);
442 } 448 }
443 } 449 }
444 450
445 } // namespace blink 451 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698