Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: WIP - fix on release, still hits CHECK in LayoutGeometryMap.cpp:156 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 994 matching lines...) Expand 10 before | Expand all | Expand 10 after
1005 bool logicalHeightComputesAsNone(SizeType) const; 1005 bool logicalHeightComputesAsNone(SizeType) const;
1006 1006
1007 bool isBox() const = delete; // This will catch anyone doing an unnecessary check. 1007 bool isBox() const = delete; // This will catch anyone doing an unnecessary check.
1008 1008
1009 void frameRectChanged() 1009 void frameRectChanged()
1010 { 1010 {
1011 // The frame rect may change because of layout of other objects. 1011 // The frame rect may change because of layout of other objects.
1012 // Should check this object for paint invalidation. 1012 // Should check this object for paint invalidation.
1013 if (!needsLayout()) 1013 if (!needsLayout())
1014 setMayNeedPaintInvalidation(); 1014 setMayNeedPaintInvalidation();
1015 invalidateScrollAncestorConstraints();
1015 } 1016 }
1016 1017
1017 // Returns true if the box intersects the viewport visible to the user. 1018 // Returns true if the box intersects the viewport visible to the user.
1018 bool intersectsVisibleViewport(); 1019 bool intersectsVisibleViewport();
1019 1020
1020 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction); 1021 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction);
1021 1022
1022 void updateBackgroundAttachmentFixedStatusAfterStyleChange(); 1023 void updateBackgroundAttachmentFixedStatusAfterStyleChange();
1023 1024
1024 // The CSS border box rect for this box. 1025 // The CSS border box rect for this box.
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 if (UNLIKELY(m_inlineBoxWrapper != nullptr)) 1132 if (UNLIKELY(m_inlineBoxWrapper != nullptr))
1132 deleteLineBoxWrapper(); 1133 deleteLineBoxWrapper();
1133 } 1134 }
1134 1135
1135 m_inlineBoxWrapper = boxWrapper; 1136 m_inlineBoxWrapper = boxWrapper;
1136 } 1137 }
1137 1138
1138 } // namespace blink 1139 } // namespace blink
1139 1140
1140 #endif // LayoutBox_h 1141 #endif // LayoutBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698