Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Merge with master and skip anonymous containing blocks for sticky container. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections. 192 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections.
193 if (style.hasAutoZIndex() && ((element && element->document().documentElemen t() == element) 193 if (style.hasAutoZIndex() && ((element && element->document().documentElemen t() == element)
194 || style.hasOpacity() 194 || style.hasOpacity()
195 || style.hasTransformRelatedProperty() 195 || style.hasTransformRelatedProperty()
196 || style.hasMask() 196 || style.hasMask()
197 || style.clipPath() 197 || style.clipPath()
198 || style.boxReflect() 198 || style.boxReflect()
199 || style.hasFilter() 199 || style.hasFilter()
200 || style.hasBlendMode() 200 || style.hasBlendMode()
201 || style.hasIsolation() 201 || style.hasIsolation()
202 || style.position() == FixedPosition 202 || style.hasViewportConstrainedPosition()
203 || isInTopLayer(element, style) 203 || isInTopLayer(element, style)
204 || hasWillChangeThatCreatesStackingContext(style) 204 || hasWillChangeThatCreatesStackingContext(style)
205 || style.containsPaint())) 205 || style.containsPaint()))
206 style.setZIndex(0); 206 style.setZIndex(0);
207 207
208 if (doesNotInheritTextDecoration(style, element)) 208 if (doesNotInheritTextDecoration(style, element))
209 style.clearAppliedTextDecorations(); 209 style.clearAppliedTextDecorations();
210 210
211 style.applyTextDecorations(); 211 style.applyTextDecorations();
212 212
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 style.setDisplay(INLINE_BLOCK); 445 style.setDisplay(INLINE_BLOCK);
446 446
447 // After performing the display mutation, check table rows. We do not honor position: relative table rows or cells. 447 // After performing the display mutation, check table rows. We do not honor position: relative table rows or cells.
448 // This has been established for position: relative in CSS2.1 (and caused a crash in containingBlock() 448 // This has been established for position: relative in CSS2.1 (and caused a crash in containingBlock()
449 // on some sites). 449 // on some sites).
450 if ((style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW_G ROUP 450 if ((style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW_G ROUP
451 || style.display() == TABLE_FOOTER_GROUP || style.display() == TABLE_ROW ) 451 || style.display() == TABLE_FOOTER_GROUP || style.display() == TABLE_ROW )
452 && style.position() == RelativePosition) 452 && style.position() == RelativePosition)
453 style.setPosition(StaticPosition); 453 style.setPosition(StaticPosition);
454 454
455 // Cannot support position: sticky for table columns and column groups becau se current code is only doing
456 // background painting through columns / column groups
457 if ((style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_COLUM N)
458 && style.position() == StickyPosition)
459 style.setPosition(StaticPosition);
460
455 // writing-mode does not apply to table row groups, table column groups, tab le rows, and table columns. 461 // writing-mode does not apply to table row groups, table column groups, tab le rows, and table columns.
456 // FIXME: Table cells should be allowed to be perpendicular or flipped with respect to the table, though. 462 // FIXME: Table cells should be allowed to be perpendicular or flipped with respect to the table, though.
457 if (style.display() == TABLE_COLUMN || style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_FOOTER_GROUP 463 if (style.display() == TABLE_COLUMN || style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_FOOTER_GROUP
458 || style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW || style.display() == TABLE_ROW_GROUP 464 || style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW || style.display() == TABLE_ROW_GROUP
459 || style.display() == TABLE_CELL) 465 || style.display() == TABLE_CELL)
460 style.setWritingMode(parentStyle.writingMode()); 466 style.setWritingMode(parentStyle.writingMode());
461 467
462 // FIXME: Since we don't support block-flow on flexible boxes yet, disallow setting 468 // FIXME: Since we don't support block-flow on flexible boxes yet, disallow setting
463 // of block-flow to anything other than TopToBottomWritingMode. 469 // of block-flow to anything other than TopToBottomWritingMode.
464 // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support. 470 // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support.
465 if (style.writingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX)) 471 if (style.writingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX))
466 style.setWritingMode(TopToBottomWritingMode); 472 style.setWritingMode(TopToBottomWritingMode);
467 473
468 if (parentStyle.isDisplayFlexibleOrGridBox()) { 474 if (parentStyle.isDisplayFlexibleOrGridBox()) {
469 style.setFloating(NoFloat); 475 style.setFloating(NoFloat);
470 style.setDisplay(equivalentBlockDisplay(style.display(), style.isFloatin g(), !m_useQuirksModeStyles)); 476 style.setDisplay(equivalentBlockDisplay(style.display(), style.isFloatin g(), !m_useQuirksModeStyles));
471 477
472 // We want to count vertical percentage paddings/margins on flex items b ecause our current 478 // We want to count vertical percentage paddings/margins on flex items b ecause our current
473 // behavior is different from the spec and we want to gather compatibili ty data. 479 // behavior is different from the spec and we want to gather compatibili ty data.
474 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t()) 480 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t())
475 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical); 481 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical);
476 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( )) 482 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( ))
477 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal); 483 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal);
478 } 484 }
479 } 485 }
480 486
481 } // namespace blink 487 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698