Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1308253005: Add some useful information to trooper doc. (Closed)

Created:
5 years, 3 months ago by dogben
Modified:
5 years, 3 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add some useful information to trooper doc. BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1308253005 Committed: https://skia.googlesource.com/skia/+/fbf908c857069b8988a3b0e7c5e706d8d392e898

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Update based on review. #

Patch Set 3 : Update with info about Chrome infra machines. #

Patch Set 4 : Minor edits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
M site/dev/sheriffing/trooper.md View 1 2 3 1 chunk +75 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
dogben
5 years, 3 months ago (2015-09-02 22:30:06 UTC) #3
borenet
LGTM with a few comments. https://codereview.chromium.org/1308253005/diff/20001/site/dev/sheriffing/trooper.md File site/dev/sheriffing/trooper.md (right): https://codereview.chromium.org/1308253005/diff/20001/site/dev/sheriffing/trooper.md#newcode53 site/dev/sheriffing/trooper.md:53: - Disconnected devices (these ...
5 years, 3 months ago (2015-09-03 12:23:05 UTC) #4
rmistry
LGTM Great job compiling this Ben! https://codereview.chromium.org/1308253005/diff/20001/site/dev/sheriffing/trooper.md File site/dev/sheriffing/trooper.md (right): https://codereview.chromium.org/1308253005/diff/20001/site/dev/sheriffing/trooper.md#newcode53 site/dev/sheriffing/trooper.md:53: - Disconnected devices ...
5 years, 3 months ago (2015-09-03 12:30:27 UTC) #5
borenet
On 2015/09/03 12:30:27, rmistry wrote: > LGTM > > Great job compiling this Ben! > ...
5 years, 3 months ago (2015-09-03 12:56:35 UTC) #6
dogben
PTAL https://codereview.chromium.org/1308253005/diff/20001/site/dev/sheriffing/trooper.md File site/dev/sheriffing/trooper.md (right): https://codereview.chromium.org/1308253005/diff/20001/site/dev/sheriffing/trooper.md#newcode53 site/dev/sheriffing/trooper.md:53: - Disconnected devices (these are detected as the ...
5 years, 3 months ago (2015-09-03 15:40:16 UTC) #7
borenet
LGTM
5 years, 3 months ago (2015-09-03 15:42:18 UTC) #8
rmistry
On 2015/09/03 15:42:18, borenet wrote: > LGTM lgtm
5 years, 3 months ago (2015-09-03 16:04:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308253005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308253005/80001
5 years, 3 months ago (2015-09-03 16:05:54 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 16:06:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/fbf908c857069b8988a3b0e7c5e706d8d392e898

Powered by Google App Engine
This is Rietveld 408576698