Source/core/frame/SubresourceIntegrity.cpp - Issue 1308253004: Fix Subresource Integrity console message for lack of CORS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/SubresourceIntegrity.cpp

Issue 1308253004: Fix Subresource Integrity console message for lack of CORS (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin-console-messages-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/SubresourceIntegrity.cpp

diff --git a/Source/core/frame/SubresourceIntegrity.cpp b/Source/core/frame/SubresourceIntegrity.cpp

index 1064ce65b1c6d73b3f5efc127f77d0b7010195f0..c91fc0fda9123bd28e89e914e2a57cf877cc5d4f 100644

--- a/Source/core/frame/SubresourceIntegrity.cpp

+++ b/Source/core/frame/SubresourceIntegrity.cpp

@@ -110,7 +110,7 @@ bool SubresourceIntegrity::CheckSubresourceIntegrity(const Element& element, con

if (!resource.isEligibleForIntegrityCheck(document.securityOrigin())) {

UseCounter::count(document, UseCounter::SRIElementIntegrityAttributeButIneligible);

- logErrorToConsole("Subresource Integrity: The resource '" + resourceUrl.elidedString() + "' has an integrity attribute, but the resource requires the request to be CORS enabled to check the integrity, and it is not. The resource has not been blocked, but no integrity check occurred.", document);

+ logErrorToConsole("Subresource Integrity: The resource '" + resourceUrl.elidedString() + "' has an integrity attribute, but the resource requires the request to be CORS enabled to check the integrity, and it is not. The resource has been blocked because the integrity cannot be enforced.", document);

return false;

}