Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 130823002: Fix *Fail* tests in unregisterProtocolHandler test (Closed)

Created:
6 years, 11 months ago by gyuyoung-inactive
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix *Fail* tests in unregisterProtocolHandler test In fast/dom/unregister-protocol-handler.html, some test field related to check an invalid url has been failed because wrong syntax error string(SYNTAX_ERR) is used so far. This cl fix it with *SyntaxError*. Additionally this cl improve error logs of unregister-protocol-handler.html. BUG=N/A TEST=LayoutTests/fast/dom/unregister-protocol-handler.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M LayoutTests/fast/dom/unregister-protocol-handler.html View 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/unregister-protocol-handler-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add abarth to reviewer.
6 years, 11 months ago (2014-01-09 05:18:56 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-10 00:25:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/130823002/1
6 years, 11 months ago (2014-01-10 00:25:31 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 02:00:15 UTC) #4
Message was sent while issue was closed.
Change committed as 164827

Powered by Google App Engine
This is Rietveld 408576698