Devtools UI: Display hint when Network panel is empty

Devtools UI: Display hint when Network panel is empty

BUG=526768
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201578

[samli, 2015-09-01 16:55:35]

samli@chromium.org changed reviewers:
+ dgozman@chromium.org

[samli, 2015-09-01 16:55:49]

Screenshot: http://i.imgur.com/bq7A0nh.png

[paulirish, 2015-09-01 17:01:34]

paulirish@chromium.org changed reviewers:
+ paulirish@chromium.org

[paulirish, 2015-09-01 17:01:34]

thanks for this. lgtm from my side.

https://codereview.chromium.org/1308213007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/network/NetworkLogView.js (right):

https://codereview.chromium.org/1308213007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/network/NetworkLogView.js:305:
recordingText.textContent = WebInspector.UIString("Recording network
activity...");
"Recording network activity\u2026"

[pfeldman, 2015-09-01 17:44:17]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-09-01 17:44:17]

lgtm % paul's comments.

[dgozman, 2015-09-01 17:47:11]

We have something similar already: http://pasteboard.co/jSWxBUp.png.

Also, I don't really like how this looks. Maybe center-align both lines, or make
it a single line?

[samli, 2015-09-01 18:03:20]

The CQ bit was checked by samli@chromium.org

[samli, 2015-09-01 18:03:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
paulirish@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1308213007/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-09-01 18:03:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308213007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308213007/40001

[samli, 2015-09-01 18:04:40]

On 2015/09/01 at 17:47:11, dgozman wrote:
> We have something similar already: http://pasteboard.co/jSWxBUp.png.
Yes, but this doesn't actually show on initial load and is not prominent enough.
Shortcuts are also helpful and this matches timeline panel.
> 
> Also, I don't really like how this looks. Maybe center-align both lines, or
make it a single line?

Centered aligned. The general styling matches timeline panel.

[dgozman, 2015-09-01 18:05:59]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2015-09-01 18:06:15]

On 2015/09/01 18:04:40, samli wrote:
> On 2015/09/01 at 17:47:11, dgozman wrote:
> > We have something similar already: http://pasteboard.co/jSWxBUp.png.
> Yes, but this doesn't actually show on initial load and is not prominent
enough.
> Shortcuts are also helpful and this matches timeline panel.
Let's nuke the old one.

[samli, 2015-09-01 21:18:57]

On 2015/09/01 at 18:06:15, dgozman wrote:
> On 2015/09/01 18:04:40, samli wrote:
> > On 2015/09/01 at 17:47:11, dgozman wrote:
> > > We have something similar already: http://pasteboard.co/jSWxBUp.png.
> > Yes, but this doesn't actually show on initial load and is not prominent
enough.
> > Shortcuts are also helpful and this matches timeline panel.
> Let's nuke the old one.

Done.

[samli, 2015-09-01 21:19:01]

The CQ bit was checked by samli@chromium.org

[samli, 2015-09-01 21:19:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
paulirish@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1308213007/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-09-01 21:19:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308213007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308213007/60001

[commit-bot: I haz the power, 2015-09-01 22:31:55]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201578

[paulirish, 2015-09-02 03:06:59]

fwiw i think you could've dropped a rule of CSS:

.network-summary-bar label[is=dt-icon-label] {
    margin-right: 6px;
}