Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1308203003: content_browsertests for stale-while-revalidate (Closed)

Created:
5 years, 4 months ago by Adam Rice
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@s-w-r-browser-content
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content_browsertests for stale-while-revalidate Validate correct end-to-end behaviour for stale-while-revalidate. BUG=348877 TEST=content_browsertests Committed: https://crrev.com/0f39f4a074e5bb473ec97e5adf50e772c769e773 Cr-Commit-Position: refs/heads/master@{#369116}

Patch Set 1 #

Patch Set 2 : Add CookieSetAsynchronously test. #

Total comments: 2

Patch Set 3 : Clarify that the RunLoop is only used in one test. #

Patch Set 4 : Rebase. #

Patch Set 5 : Move tests to async_revalidation_manager_browsertest.cc #

Patch Set 6 : Rebase. #

Total comments: 17

Patch Set 7 : Fixes from kinuko review. #

Patch Set 8 : Remove excess blank line. #

Total comments: 2

Patch Set 9 : Flake protection for CacheIsUpdated test. #

Patch Set 10 : Make CacheIsUpdated test deterministic. Also modify CheckTestTest() to TitleBecomes() for better di… #

Patch Set 11 : Add missing base:: prefix to UTF16ToUTF8 function. #

Total comments: 4

Patch Set 12 : Remove unreachable failure diagnostics from TitleBecomes(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -0 lines) Patch
A content/browser/loader/async_revalidation_manager_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +220 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 32 (8 generated)
Adam Rice
5 years, 3 months ago (2015-08-27 19:05:13 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/1308203003/diff/20001/content/browser/loader/resource_dispatcher_host_browsertest.cc File content/browser/loader/resource_dispatcher_host_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/20001/content/browser/loader/resource_dispatcher_host_browsertest.cc#newcode562 content/browser/loader/resource_dispatcher_host_browsertest.cc:562: scoped_ptr<HttpResponse> CountingRequestHandler(const HttpRequest& request) { this is special ...
5 years, 3 months ago (2015-08-31 09:37:46 UTC) #3
Adam Rice
https://codereview.chromium.org/1308203003/diff/20001/content/browser/loader/resource_dispatcher_host_browsertest.cc File content/browser/loader/resource_dispatcher_host_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/20001/content/browser/loader/resource_dispatcher_host_browsertest.cc#newcode562 content/browser/loader/resource_dispatcher_host_browsertest.cc:562: scoped_ptr<HttpResponse> CountingRequestHandler(const HttpRequest& request) { On 2015/08/31 09:37:46, tyoshino ...
5 years, 3 months ago (2015-09-01 00:38:09 UTC) #4
tyoshino (SeeGerritForStatus)
thanks. lgtm again in case you're waiting for it
5 years, 3 months ago (2015-09-08 06:27:48 UTC) #5
Adam Rice
+davidben
5 years, 3 months ago (2015-09-08 18:43:12 UTC) #7
cbentzel
On 2015/09/08 18:43:12, Adam Rice wrote: > +davidben Is this still active?
5 years, 1 month ago (2015-11-10 05:43:23 UTC) #8
Adam Rice
On 2015/11/10 05:43:23, cbentzel wrote: > On 2015/09/08 18:43:12, Adam Rice wrote: > > +davidben ...
5 years, 1 month ago (2015-11-10 17:47:16 UTC) #9
Adam Rice
-davidben, +kinuko Reducing davidben's review load.
5 years ago (2015-12-07 22:42:04 UTC) #12
kinuko
https://codereview.chromium.org/1308203003/diff/100001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/100001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode50 content/browser/loader/async_revalidation_manager_browsertest.cc:50: int requests_counted() { return requests_counted_; } nit: can be ...
5 years ago (2015-12-15 15:28:54 UTC) #13
Adam Rice
https://codereview.chromium.org/1308203003/diff/100001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/100001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode50 content/browser/loader/async_revalidation_manager_browsertest.cc:50: int requests_counted() { return requests_counted_; } On 2015/12/15 15:28:54, ...
4 years, 11 months ago (2016-01-05 09:21:44 UTC) #14
Adam Rice
https://codereview.chromium.org/1308203003/diff/100001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/100001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode134 content/browser/loader/async_revalidation_manager_browsertest.cc:134: return http_response.Pass(); On 2016/01/05 09:21:44, Adam Rice (ooo until ...
4 years, 11 months ago (2016-01-05 11:40:32 UTC) #15
kinuko
Mostly looking good, I wonder if there's a way to make the test with kMaxLoads ...
4 years, 11 months ago (2016-01-05 13:43:54 UTC) #16
Adam Rice
https://codereview.chromium.org/1308203003/diff/140001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/140001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode188 content/browser/loader/async_revalidation_manager_browsertest.cc:188: for (int loads = 0; loads < kMaxLoads && ...
4 years, 11 months ago (2016-01-05 14:38:46 UTC) #17
kinuko
On 2016/01/05 14:38:46, Adam Rice (ooo until 5 Jan) wrote: > https://codereview.chromium.org/1308203003/diff/140001/content/browser/loader/async_revalidation_manager_browsertest.cc > File content/browser/loader/async_revalidation_manager_browsertest.cc ...
4 years, 11 months ago (2016-01-06 03:44:05 UTC) #18
Adam Rice
On 2016/01/06 03:44:05, kinuko wrote: > Ok... do you know if we have similar tests ...
4 years, 11 months ago (2016-01-06 06:09:42 UTC) #19
kinuko
I'm really glad that we no longer need to loop! https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode72 ...
4 years, 11 months ago (2016-01-06 08:17:13 UTC) #20
Adam Rice
https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode72 content/browser/loader/async_revalidation_manager_browsertest.cc:72: << actual_title << "'"; On 2016/01/06 08:17:13, kinuko wrote: ...
4 years, 11 months ago (2016-01-06 08:32:27 UTC) #21
kinuko
https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode72 content/browser/loader/async_revalidation_manager_browsertest.cc:72: << actual_title << "'"; On 2016/01/06 08:32:26, Adam Rice ...
4 years, 11 months ago (2016-01-06 08:44:52 UTC) #22
Adam Rice
https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc File content/browser/loader/async_revalidation_manager_browsertest.cc (right): https://codereview.chromium.org/1308203003/diff/200001/content/browser/loader/async_revalidation_manager_browsertest.cc#newcode72 content/browser/loader/async_revalidation_manager_browsertest.cc:72: << actual_title << "'"; On 2016/01/06 08:44:52, kinuko wrote: ...
4 years, 11 months ago (2016-01-12 13:20:30 UTC) #23
kinuko
lgtm
4 years, 11 months ago (2016-01-13 06:15:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308203003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308203003/220001
4 years, 11 months ago (2016-01-13 06:19:45 UTC) #27
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years, 11 months ago (2016-01-13 07:14:26 UTC) #29
commit-bot: I haz the power
Failed to apply the patch.
4 years, 11 months ago (2016-01-13 07:14:42 UTC) #30
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 07:15:40 UTC) #32
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/0f39f4a074e5bb473ec97e5adf50e772c769e773
Cr-Commit-Position: refs/heads/master@{#369116}

Powered by Google App Engine
This is Rietveld 408576698