Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1308183006: Move FormDataList::deleteEntry() and hasEntry() to DOMFormData. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move FormDataList::deleteEntry() and hasEntry() to DOMFormData. - Move FormDataList::deleteEntry() to DOMFormData - Fold FormDataList::hasEntry() into DOMFormData::has(). This CL has no behavior changes. BUG=528840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201951

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -30 lines) Patch
M Source/core/html/DOMFormData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/DOMFormData.cpp View 2 chunks +19 lines, -1 line 1 comment Download
M Source/core/html/DOMFormDataTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/FormDataList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/FormDataList.cpp View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 3 months ago (2015-09-08 07:17:07 UTC) #2
keishi
LGTM https://codereview.chromium.org/1308183006/diff/1/Source/core/html/DOMFormData.cpp File Source/core/html/DOMFormData.cpp (right): https://codereview.chromium.org/1308183006/diff/1/Source/core/html/DOMFormData.cpp#newcode128 Source/core/html/DOMFormData.cpp:128: if (m_items[i].key() == keyData) { nit: extra brackets
5 years, 3 months ago (2015-09-09 04:18:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308183006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308183006/1
5 years, 3 months ago (2015-09-09 04:23:05 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 04:27:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201951

Powered by Google App Engine
This is Rietveld 408576698