Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1308173005:
Lookout for the scrollbarModes when force style change occurs. (Closed)
|
Created:
5 years, 3 months ago by MuVen Modified:
5 years, 2 months ago Reviewers:
skobes CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLookout for the scrollbarModes when force style change occurs.
Lookout for the scrollbarModes when force style change occurs and reset
the needs Horizontal & vertical Scrollbar values based on
scrollbarModes, as during force style change
StyleResolver::styleForDocument returns documentStyle with no overflow
values, due to which we are destorying the scrollbars that was already
present.
TESTED= scrollbars/custom-scrollbar-changing-style.html
now passes with root layer scrolling
BUG=522389
Committed: https://crrev.com/9b38e6e3a809470c4c8414aae3308ad10578c617
Cr-Commit-Position: refs/heads/master@{#351059}
Patch Set 1 : #Patch Set 2 : #Patch Set 3 : updated as per review comments #Patch Set 4 : Rebased to latest #Messages
Total messages: 43 (26 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Patchset #1 (id:120001) has been deleted
sataya.m@samsung.com changed reviewers: + skobes@chromium.org
Patchset #2 (id:160001) has been deleted
Patchset #1 (id:140001) has been deleted
Hi Skobes, PTAL. Thanks,
The computed style of the document node shouldn't depend on the style of the html element. We should instead fix the scrollbar code to look at the appropriate styles.
Patchset #2 (id:200001) has been deleted
skobes, PTAL & share your inputs.
On 2015/09/22 15:08:50, MuVen wrote: > skobes, PTAL & share your inputs. It looks like the FrameView equivalent of this logic is in FrameView::calculateScrollbarModesForLayout and FrameView::applyOverflowToViewport, and it is rather more complex, taking into account the overflow styles on <body> and <html>, the value of FrameView::m_canHaveScrollbars which is set in various ways, the scrolling="yes|no" attribute on an <iframe> element, an android webview quirk (shouldIgnoreOverflowHidden), and special cases for svg and <frameset>. Since none of that code intersects with FrameView's implementation of ScrollableArea, I think in this case it makes sense for DeprecatedPaintLayerScrollableArea::updateAfterStyleChange to just call FrameView::calculateScrollbarModesForLayout rather than reimplementing it.
Patchset #3 (id:240001) has been deleted
PTAL
lgtm
The CQ bit was checked by sataya.m@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/260001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sataya.m@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/260001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by sataya.m@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org Link to the patchset: https://codereview.chromium.org/1308173005/#ps280001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/280001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #4 (id:280001) has been deleted
The CQ bit was checked by sataya.m@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org Link to the patchset: https://codereview.chromium.org/1308173005/#ps300001 (title: "rebased to latest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/300001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
Patchset #4 (id:300001) has been deleted
The CQ bit was checked by sataya.m@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org Link to the patchset: https://codereview.chromium.org/1308173005/#ps320001 (title: "Rebased to latest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/320001
Message was sent while issue was closed.
Committed patchset #4 (id:320001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9b38e6e3a809470c4c8414aae3308ad10578c617 Cr-Commit-Position: refs/heads/master@{#351059} |
