Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1308173005: Lookout for the scrollbarModes when force style change occurs. (Closed)

Created:
5 years, 3 months ago by MuVen
Modified:
5 years, 2 months ago
Reviewers:
skobes
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lookout for the scrollbarModes when force style change occurs. Lookout for the scrollbarModes when force style change occurs and reset the needs Horizontal & vertical Scrollbar values based on scrollbarModes, as during force style change StyleResolver::styleForDocument returns documentStyle with no overflow values, due to which we are destorying the scrollbars that was already present. TESTED= scrollbars/custom-scrollbar-changing-style.html now passes with root layer scrolling BUG=522389 Committed: https://crrev.com/9b38e6e3a809470c4c8414aae3308ad10578c617 Cr-Commit-Position: refs/heads/master@{#351059}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : updated as per review comments #

Patch Set 4 : Rebased to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (26 generated)
MuVen
Hi Skobes, PTAL. Thanks,
5 years, 3 months ago (2015-09-07 09:28:09 UTC) #11
skobes
The computed style of the document node shouldn't depend on the style of the html ...
5 years, 3 months ago (2015-09-12 02:45:11 UTC) #12
MuVen
skobes, PTAL & share your inputs.
5 years, 3 months ago (2015-09-22 15:08:50 UTC) #14
skobes
On 2015/09/22 15:08:50, MuVen wrote: > skobes, PTAL & share your inputs. It looks like ...
5 years, 3 months ago (2015-09-22 21:54:43 UTC) #15
MuVen
PTAL
5 years, 3 months ago (2015-09-23 12:12:15 UTC) #17
skobes
lgtm
5 years, 3 months ago (2015-09-24 20:24:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/260001
5 years, 2 months ago (2015-09-27 04:24:31 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/124577) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-27 04:25:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/260001
5 years, 2 months ago (2015-09-28 08:09:00 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/124695) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-28 08:10:00 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/280001
5 years, 2 months ago (2015-09-28 08:47:47 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/124704) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-28 08:48:35 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/300001
5 years, 2 months ago (2015-09-28 11:15:44 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/9713)
5 years, 2 months ago (2015-09-28 11:25:16 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308173005/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308173005/320001
5 years, 2 months ago (2015-09-28 11:33:09 UTC) #41
commit-bot: I haz the power
Committed patchset #4 (id:320001)
5 years, 2 months ago (2015-09-28 12:47:39 UTC) #42
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 12:48:30 UTC) #43
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9b38e6e3a809470c4c8414aae3308ad10578c617
Cr-Commit-Position: refs/heads/master@{#351059}

Powered by Google App Engine
This is Rietveld 408576698