Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1308163009: Revert of Switch blink repo to use chromium-status.appspot.com (Closed)

Created:
5 years, 3 months ago by Paweł Hajdan Jr.
Modified:
5 years, 3 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Switch blink repo to use chromium-status.appspot.com (patchset #1 id:1 of https://codereview.chromium.org/1315323007/ ) Reason for revert: This moves chromium.webkit off blink tab to chromium tab on sheriff-o-matic, which is undesired (https://code.google.com/p/chromium/issues/detail?id=528346) Original issue's description: > Switch blink repo to use chromium-status.appspot.com > > See https://groups.google.com/a/chromium.org/d/msg/blink-dev/S-P3N0kdkMM/EypTXImtAwAJ > for context. > > R=akuegel@chromium.org, akuegel > TBR=jochen > > BUG=431478 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201792 TBR=akuegel@chromium.org,tandrii@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=431478, 528346 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +1 line, -1 line 0 comments Download
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M infra/config/cq.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Paweł Hajdan Jr.
Created Revert of Switch blink repo to use chromium-status.appspot.com
5 years, 3 months ago (2015-09-04 17:44:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308163009/1
5 years, 3 months ago (2015-09-04 17:44:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201808
5 years, 3 months ago (2015-09-04 17:45:21 UTC) #4
Adrian Kuegel
5 years, 3 months ago (2015-09-07 07:50:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698