runtime/vm/ast_transformer.h - Issue 1308163006: Reduce the number of captured variables in async code, by only capturing local

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast_transformer.h

Issue 1308163006: Reduce the number of captured variables in async code, by only capturing local (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/ast_transformer.h

diff --git a/runtime/vm/ast_transformer.h b/runtime/vm/ast_transformer.h

index 807f7cf171a743caad2c7526074adccf0b30842a..e9f67910746998e1abe29ceda42ed922f8903b2f 100644

--- a/runtime/vm/ast_transformer.h

+++ b/runtime/vm/ast_transformer.h

@@ -39,7 +39,7 @@ class Thread;

class AwaitTransformer : public AstNodeVisitor {

public:

- AwaitTransformer(SequenceNode* preamble, LocalScope* function_top);

+ AwaitTransformer(SequenceNode* preamble, LocalScope* async_temp_scope);

#define DECLARE_VISIT(BaseName) \

virtual void Visit##BaseName##Node(BaseName##Node* node);

@@ -66,7 +66,7 @@ class AwaitTransformer : public AstNodeVisitor {

SequenceNode* preamble_;

int32_t temp_cnt_;

AstNode* result_;

- LocalScope* function_top_;

+ LocalScope* async_temp_scope_;

Thread* thread_;

« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/ast_transformer.cc » ('j') | no next file with comments »