Oilpan: Give a chance to schedule a precise GC after V8 minor and major GCs

Oilpan: Give a chance to schedule a precise GC after V8 minor and major GCs

I manually created more than 80 Chromium builds with various GC parameters and investigated a way to reduce the peak memory increase in memory.top_7_stress. This CL reduces the peak memory of Blogger by 6%, WordPress by 3% etc.

This CL does the following two things:

- Finish completeSweep() before starting a V8 minor GC.
- Give a chance to schedule a precise GC after V8 minor and major GCs.

BUG=474470
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201050

[haraken, 2015-08-23 23:47:31]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, yutak@chromium.org

[haraken, 2015-08-23 23:47:37]

PTAL

[Yuta Kitamura, 2015-08-24 03:59:47]

The change seems fair, LGTM.

[haraken, 2015-08-24 04:00:27]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-08-24 04:00:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308163003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308163003/20001

[commit-bot: I haz the power, 2015-08-24 05:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 05:11:55]

Failed to apply patch for Source/platform/heap/ThreadState.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/heap/ThreadState.cpp
  Hunk #1 FAILED at 657.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/platform/heap/ThreadState.cpp.rej

Patch:       Source/platform/heap/ThreadState.cpp
Index: Source/platform/heap/ThreadState.cpp
diff --git a/Source/platform/heap/ThreadState.cpp
b/Source/platform/heap/ThreadState.cpp
index
0b06ceacab0bb033d7d863562c7c7acf73d172a3..ac82d0247a3fefb3d36f3d078f9a1002db3603b5
100644
--- a/Source/platform/heap/ThreadState.cpp
+++ b/Source/platform/heap/ThreadState.cpp
@@ -657,9 +657,14 @@ bool ThreadState::shouldSchedulePreciseGC()
 #endif
 }
 
+bool ThreadState::shouldScheduleV8FollowupGC()
+{
+    return judgeGCThreshold(32 * 1024 * 1024, 1.5);
+}
+
 bool ThreadState::shouldSchedulePageNavigationGC(float estimatedRemovalRatio)
 {
-    return judgeGCThreshold(1024 * 1024, 1.5);
+    return judgeGCThreshold(1024 * 1024, 1.5 * (1 - estimatedRemovalRatio));
 }
 
 bool ThreadState::shouldForceConservativeGC()
@@ -668,6 +673,21 @@ bool ThreadState::shouldForceConservativeGC()
     return judgeGCThreshold(32 * 1024 * 1024, 5.0);
 }
 
+void ThreadState::scheduleV8FollowupGCIfNeeded()
+{
+    ASSERT(checkThread());
+    if (isGCForbidden())
+        return;
+
+    if (isSweepingInProgress())
+        return;
+    ASSERT(!sweepForbidden());
+
+    Heap::reportMemoryUsageForTracing();
+    if (shouldScheduleV8FollowupGC())
+        schedulePreciseGC();
+}
+
 void ThreadState::schedulePageNavigationGCIfNeeded(float estimatedRemovalRatio)
 {
     ASSERT(checkThread());

[sof, 2015-08-24 05:12:35]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-08-24 05:12:35]

https://codereview.chromium.org/1308163003/diff/20001/Source/platform/heap/Th...
File Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/1308163003/diff/20001/Source/platform/heap/Th...
Source/platform/heap/ThreadState.cpp:667: return judgeGCThreshold(1024 * 1024,
1.5 * (1 - estimatedRemovalRatio));
This change isn't covered by the description; intentionally included?

[haraken, 2015-08-24 05:14:15]

https://codereview.chromium.org/1308163003/diff/20001/Source/platform/heap/Th...
File Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/1308163003/diff/20001/Source/platform/heap/Th...
Source/platform/heap/ThreadState.cpp:667: return judgeGCThreshold(1024 * 1024,
1.5 * (1 - estimatedRemovalRatio));
On 2015/08/24 05:12:35, sof wrote:
> This change isn't covered by the description; intentionally included?

This change has been already landed. Forgot to rebase the CL with ToT.

[haraken, 2015-08-24 05:15:32]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-08-24 05:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1308163003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-24 05:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308163003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308163003/40001

[commit-bot: I haz the power, 2015-08-24 06:56:16]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201050