Issue 1308163002: Add optional streamId param to Tracing.tracingComplete in DevTools protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1308163002: Add optional streamId param to Tracing.tracingComplete in DevTools protocol (Closed)

Created:
5 years, 4 months ago by caseq

Modified:
5 years, 3 months ago

Reviewers:
dgozman, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add optional streamId param to Tracing.tracingComplete in DevTools protocol This prepares protocol.json for chromium-side changes that enabled passing traces as streams (https://codereview.chromium.org/1307073002) BUG=456845

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	Source/devtools/protocol.json	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pfeldman

5 years, 4 months ago (2015-08-24 17:48:25 UTC) #3

lgtm

https://codereview.chromium.org/1308163002/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/1308163002/diff/1/Source/devtools/protocol.js...
Source/devtools/protocol.json:4855: { "name": "streamId", "type": "string",
"optional": true, "description": "The id of the stream that holds resulting
trace data." }
Lets introduce a type for this.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages