Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test by adding EDITABLE role manually. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index 93d84137ecd51970348f9b5e8e9f2419ea449035..150d0f4301f99a4204517ded1dc48e097263dfae 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -641,18 +641,7 @@ bool BrowserAccessibility::IsCellOrTableHeaderRole() const {
}
bool BrowserAccessibility::IsEditableText() const {
- // These roles don't have readonly set, but they're not editable text.
- if (GetRole() == ui::AX_ROLE_SCROLL_AREA ||
- GetRole() == ui::AX_ROLE_COLUMN ||
- GetRole() == ui::AX_ROLE_TABLE_HEADER_CONTAINER) {
- return false;
- }
-
- // Note: WebAXStateReadonly being false means it's either a text control,
- // or contenteditable. We also check for the text field role to cover
- // elements that have role=textbox set on it.
- return (!HasState(ui::AX_STATE_READ_ONLY) ||
- GetRole() == ui::AX_ROLE_TEXT_FIELD);
+ return HasState(ui::AX_STATE_EDITABLE);
}
bool BrowserAccessibility::IsWebAreaForPresentationalIframe() const {

Powered by Google App Engine
This is Rietveld 408576698