content/renderer/accessibility/blink_ax_enum_conversion.cc - Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_tree_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_enum_conversion.cc

diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc

index a48994a8a76368527ec1f9d971773b036e575bae..e5e7e0b235d3ed5b72767d3b5d6be486cc2f31ae 100644

--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc

+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc

@@ -67,15 +67,21 @@ uint32 AXStateFromBlink(const blink::WebAXObject& o) {

if (o.canSetSelectedAttribute())

state |= (1 << ui::AX_STATE_SELECTABLE);

+ if (o.isEditable())

+ state |= (1 << ui::AX_STATE_EDITABLE);

+ if (o.isEnabled())

+ state |= (1 << ui::AX_STATE_ENABLED);

if (o.isSelected())

state |= (1 << ui::AX_STATE_SELECTED);

+ if (o.isRichlyEditable())

+ state |= (1 << ui::AX_STATE_RICHLY_EDITABLE);

if (o.isVisited())

state |= (1 << ui::AX_STATE_VISITED);

- if (o.isEnabled())

- state |= (1 << ui::AX_STATE_ENABLED);

if (o.orientation() == blink::WebAXOrientationVertical)

state |= (1 << ui::AX_STATE_VERTICAL);

else if (o.orientation() == blink::WebAXOrientationHorizontal)