content/browser/accessibility/browser_accessibility_win.cc - Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 76d15c781ee1483f5875d06a18d728e1b57ece95..9fc5e331d0709c357fac843e2eb51697fbc5b7f9 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -3753,7 +3753,9 @@ void BrowserAccessibilityWin::GetSelectionOffsets(

int* selection_start, int* selection_end) const {

DCHECK(selection_start && selection_end);

- if (GetIntAttribute(ui::AX_ATTR_TEXT_SEL_START, selection_start) &&

+ if (HasState(ui::AX_STATE_EDITABLE) &&

dmazzoni 2015/09/08 21:18:44 We already have IsEditableText - could you modify

+ !HasState(ui::AX_STATE_RICHLY_EDITABLE) &&

+ GetIntAttribute(ui::AX_ATTR_TEXT_SEL_START, selection_start) &&

GetIntAttribute(ui::AX_ATTR_TEXT_SEL_END, selection_end)) {

return;

}