[Chromecast] Plumbs raw audio through CMA backend.

chromecast/browser/cast_content_browser_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_content_browser_client.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/files/scoped_file.h"
 #include "base/i18n/rtl.h"
 #include "base/path_service.h"
 #include "chromecast/base/cast_paths.h"
 #include "chromecast/base/chromecast_switches.h"
 #include "chromecast/browser/cast_browser_context.h"
 #include "chromecast/browser/cast_browser_main_parts.h"
 #include "chromecast/browser/cast_browser_process.h"
 #include "chromecast/browser/cast_network_delegate.h"
 #include "chromecast/browser/cast_quota_permission_context.h"
 #include "chromecast/browser/cast_resource_dispatcher_host_delegate.h"
 #include "chromecast/browser/geolocation/cast_access_token_store.h"
 #include "chromecast/browser/media/cma_message_filter_host.h"
 #include "chromecast/browser/url_request_context_factory.h"
 #include "chromecast/common/global_descriptors.h"
+#include "chromecast/media/audio/audio_manager_factory.h"
 #include "chromecast/media/base/media_message_loop.h"
 #include "chromecast/public/cast_media_shlib.h"
 #include "chromecast/public/media/media_pipeline_backend.h"
 #include "components/crash/app/breakpad_linux.h"
 #include "components/crash/browser/crash_handler_host_linux.h"
 #include "components/network_hints/browser/network_hints_message_filter.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/certificate_request_result_type.h"
 #include "content/public/browser/client_certificate_delegate.h"
 #include "content/public/browser/render_process_host.h"
@@ skipping 31 matching lines @@
     base::CommandLine* command_line) {
 }
 
 std::vector<scoped_refptr<content::BrowserMessageFilter>>
 CastContentBrowserClient::GetBrowserMessageFilters() {
   return std::vector<scoped_refptr<content::BrowserMessageFilter>>();
 }
 
 scoped_ptr<::media::AudioManagerFactory>
 CastContentBrowserClient::CreateAudioManagerFactory() {
-  // Return nullptr. The factory will not be set, and the statically linked
+  LOG(INFO) << __FUNCTION__;

[halliwell, 2015/08/28 15:14:18]

remove

[alokp, 2015/09/01 00:23:11]

Done.

+#if defined(OS_ANDROID)
+  // Return nullptr. The factory will not be set, and the default
   // implementation of AudioManager will be used.
   return scoped_ptr<::media::AudioManagerFactory>();
+#else
+  return make_scoped_ptr(new media::AudioManagerFactory);
+#endif
 }

[halliwell, 2015/08/28 15:14:18]

Question: why do we need this function now?  Isn't the point of going through
CMA to eliminate platform-specific AudioManagerFactory implementations?

[slan, 2015/08/31 16:59:56]

Right. In fact, this probably doesn't even need to be passed in to
CastBrowserMainParts anymore. It should just call
SetFactory(chromecast::AudioManagerFactory()), unless on Android.

[alokp, 2015/09/01 00:23:11]

Long story - I will explain this offline.

 
 #if !defined(OS_ANDROID)
 scoped_ptr<media::MediaPipelineBackend>
 CastContentBrowserClient::CreateMediaPipelineBackend(
     const media::MediaPipelineDeviceParams& params) {
   return make_scoped_ptr(
       media::CastMediaShlib::CreateMediaPipelineBackend(params));
 }
 #endif
 
@@ skipping 347 matching lines @@
         process_type, dumps_path, false /* upload */);
   // StartUploaderThread() even though upload is diferred.
   // Breakpad-related memory is freed in the uploader thread.
   crash_handler->StartUploaderThread();
   return crash_handler;
 }
 #endif  // !defined(OS_ANDROID)
 
 }  // namespace shell
 }  // namespace chromecast