Remove the user gesture restriction for HTMLMediaElement::pause()

Remove the user gesture restriction for HTMLMediaElement::pause()

This is very nearly dead code, because when the setting is enabled, the
only way to play a video is using play(), which removes all restrictions
if it succeeds. Therefore, the only observable behavior from the pause
restriction is that if pause() is called from an input event handler
when networkState is NETWORK_EMPTY, LoadMediaResource is scheduled.

Further, it hardly seems like a useful restriction even if it worked.
Web sites that pause a video against the will of the user seem rather
improbable. Possibly the restriction was originally added to guard the
scheduling of LoadMediaResource.

Preventing LoadMediaResource is not useful, since there are several
other ways to trigger a load, e.g. just <video src="foo"> in markup.

Note that there was no test for this restriction, but there are tests
for load(), play() and autoplay.

BUG=342339
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166888

[philipj_slow, 2014-02-10 12:53:14]

Patch 1

[philipj_slow, 2014-02-10 12:57:40]

https://codereview.chromium.org/130813006/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (left):

https://codereview.chromium.org/130813006/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:2204: // 4.8.10.9. Playing the media
resource
I removed this comment because it's out-of-date and the immediately following
step is actually not per spec. I'll add new spec references when I split pause
into pause and "internal pause steps"

[acolwell GONE FROM CHROMIUM, 2014-02-10 21:51:19]

lgtm

[philipj_slow, 2014-02-11 00:47:53]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-02-11 00:48:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/130813006/1

[commit-bot: I haz the power, 2014-02-11 02:34:51]

Change committed as 166888