Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 130813003: Create signin component and componentize TokenWebData. (Closed)

Created:
6 years, 11 months ago by blundell
Modified:
6 years, 11 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, tim+watch_chromium.org, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rsimha+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Create signin component and componentize TokenWebData. This CL creates the signin layered component. It additionally componentizes TokenWebData and moves it into the signin component. The refactorings performed on TokenWebData are identical to ones performed on AutofillWebDataService: - threads are injected rather than being obtained from content::BrowserThread - //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory instead of TokenWebData::FromBrowserContext. This CL is an unchanged reland of https://codereview.chromium.org/109783003/, which had been speculatively reverted to see if it was causing ChromeOS build failures. The speculative revert unfortunately stuck as it happened to land in the same run as the CL that actually fixed the (unrelated) ChromeOS build failures: https://codereview.chromium.org/129343003/. BUG=332107 TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -538 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
D chrome/browser/webdata/token_service_table.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/webdata/token_service_table.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/webdata/token_service_table_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/webdata/token_web_data.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/webdata/token_web_data.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 5 chunks +16 lines, -19 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
A components/signin.gypi View 1 chunk +27 lines, -0 lines 0 comments Download
A + components/signin/DEPS View 1 chunk +5 lines, -3 lines 0 comments Download
A + components/signin/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/signin/README View 1 chunk +9 lines, -0 lines 0 comments Download
A + components/signin/core/webdata/token_service_table.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/signin/core/webdata/token_service_table.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/signin/core/webdata/token_service_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/signin/core/webdata/token_web_data.h View 3 chunks +12 lines, -11 lines 0 comments Download
A + components/signin/core/webdata/token_web_data.cc View 3 chunks +17 lines, -21 lines 0 comments Download
M components/webdata/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_data_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blundell
6 years, 11 months ago (2014-01-09 10:12:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/130813003/1
6 years, 11 months ago (2014-01-09 10:13:11 UTC) #2
commit-bot: I haz the power
Change committed as 243872
6 years, 11 months ago (2014-01-09 12:43:46 UTC) #3
Noam Samuel
6 years, 11 months ago (2014-01-09 19:42:14 UTC) #4
Message was sent while issue was closed.
On 2014/01/09 12:43:46, I haz the power (commit-bot) wrote:
> Change committed as 243872

lgtm

Powered by Google App Engine
This is Rietveld 408576698