Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: test/mjsunit/harmony/destructuring.js

Issue 1308123007: [es6] conditionally ignore TDZ semantics for formals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scopes.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/destructuring.js
diff --git a/test/mjsunit/harmony/destructuring.js b/test/mjsunit/harmony/destructuring.js
index 703e521912eb2b6bee292c9271142fa08028c477..4fae90c64a1dd87ba1d860fcebc27da4ed67515e 100644
--- a/test/mjsunit/harmony/destructuring.js
+++ b/test/mjsunit/harmony/destructuring.js
@@ -956,8 +956,10 @@
function ok2(x) { 'use strict'; { let x = 2; return x; } };
assertEquals(2, ok2(1));
- assertThrows("function f({x}) { var x; }; f({});", SyntaxError);
- assertThrows("function f({x}) { { var x; } }; f({});", SyntaxError);
+ assertDoesNotThrow("function f({x}) { var x; }; f({});");
adamk 2015/09/09 00:07:02 So this is no longer an error, but yet function f
caitp (gmail) 2015/09/09 00:24:48 That's a known issue. I have two plans to fix it.
+ assertDoesNotThrow("function f({x}) { { var x; } }; f({});");
+ assertDoesNotThrow("'use strict'; function f({x}) { var x; }; f({});");
+ assertDoesNotThrow("'use strict'; function f({x}) { { var x; } }; f({});");
assertThrows("'use strict'; function f(x) { let x = 0; }; f({});", SyntaxError);
assertThrows("'use strict'; function f({x}) { let x = 0; }; f({});", SyntaxError);
}());
« no previous file with comments | « src/scopes.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698