 Chromium Code Reviews
 Chromium Code Reviews Issue 1308123006:
  [V8] Report JSON parser script to DevTools  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1308123006:
  [V8] Report JSON parser script to DevTools  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/json-parser.h | 
| diff --git a/src/json-parser.h b/src/json-parser.h | 
| index 3ee874930411579ed88fd067237e3cd491f2ddcd..1833256a1ce25cf38677e875d5edd542e2b4fe43 100644 | 
| --- a/src/json-parser.h | 
| +++ b/src/json-parser.h | 
| @@ -7,6 +7,7 @@ | 
| #include "src/char-predicates.h" | 
| #include "src/conversions.h" | 
| +#include "src/debug/debug.h" | 
| #include "src/factory.h" | 
| #include "src/messages.h" | 
| #include "src/scanner.h" | 
| @@ -244,9 +245,9 @@ MaybeHandle<Object> JsonParser<seq_one_byte>::ParseJson() { | 
| break; | 
| } | 
| - MessageLocation location(factory->NewScript(source_), | 
| - position_, | 
| - position_ + 1); | 
| + Handle<Script> script(factory->NewScript(source_)); | 
| + isolate()->debug()->OnAfterCompile(script); | 
| 
yurys
2015/08/27 00:06:57
Can you add a test for this please?
 
Yang
2015/08/27 10:41:04
And please add a comment on why this is necessary.
 
kozy
2015/08/27 18:22:05
Done.
 
kozy
2015/08/27 18:22:05
Done.
 | 
| + MessageLocation location(script, position_, position_ + 1); | 
| Handle<Object> error = factory->NewSyntaxError(message, argument); | 
| return isolate()->template Throw<Object>(error, &location); | 
| } |