Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1867)

Issue 1308123006: [V8] Report JSON parser script to DevTools (Closed)

Created:
5 years, 3 months ago by kozy
Modified:
5 years, 3 months ago
Reviewers:
Yang, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Report JSON parser script to DevTools If JSON contains SyntaxError then V8 will report exception and won't report compile error. LOG=Y BUG=chromium:515382 R=yangguo@chromium.org,yurys@chromium.org Committed: https://crrev.com/951f6b7a88fccbe14a6ddd8611e7bd98f9f7f7b1 Cr-Commit-Position: refs/heads/master@{#30426}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/json-parser.h View 1 2 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
kozy
Yury and Yang, please take a look!
5 years, 3 months ago (2015-08-27 00:03:49 UTC) #1
yurys
https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h File src/json-parser.h (right): https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h#newcode249 src/json-parser.h:249: isolate()->debug()->OnAfterCompile(script); Can you add a test for this please?
5 years, 3 months ago (2015-08-27 00:06:57 UTC) #2
Yang
https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h File src/json-parser.h (right): https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h#newcode249 src/json-parser.h:249: isolate()->debug()->OnAfterCompile(script); And please add a comment on why this ...
5 years, 3 months ago (2015-08-27 10:41:04 UTC) #3
kozy
All done. Please take a look. https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h File src/json-parser.h (right): https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h#newcode249 src/json-parser.h:249: isolate()->debug()->OnAfterCompile(script); On 2015/08/27 ...
5 years, 3 months ago (2015-08-27 18:22:06 UTC) #5
Yang
On 2015/08/27 18:22:06, kozyatinskiy wrote: > All done. Please take a look. > > https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h ...
5 years, 3 months ago (2015-08-27 18:43:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308123006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308123006/40001
5 years, 3 months ago (2015-08-27 18:46:02 UTC) #8
yurys
lgtm
5 years, 3 months ago (2015-08-27 18:47:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308123006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308123006/40001
5 years, 3 months ago (2015-08-27 18:47:53 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-08-27 19:01:08 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 19:01:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/951f6b7a88fccbe14a6ddd8611e7bd98f9f7f7b1
Cr-Commit-Position: refs/heads/master@{#30426}

Powered by Google App Engine
This is Rietveld 408576698