chrome/browser/download/save_page_browsertest.cc - Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-test

Patch Set: Addressed most of CR feedback from Nasko. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/save_page_browsertest.cc

diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc

index b47b3bec65962fa74d00d62ef37be132f94c8c6b..19c3478e437c09053ac030961614889592187ed0 100644

--- a/chrome/browser/download/save_page_browsertest.cc

+++ b/chrome/browser/download/save_page_browsertest.cc

@@ -785,7 +785,7 @@ class SavePageSitePerProcessBrowserTest : public SavePageBrowserTest {

// TODO(lukasza): Enable --site-per-process once crbug.com/526786 is fixed.

// (currently, when the line below is uncommented out, the test crashes

- // under RenderViewImpl::OnGetAllSavableResourceLinksForCurrentPage).

+ // under RenderViewImpl::OnGetSerializedHtmlDataForCu...PageWithLocalLinks).

// content::IsolateAllSitesForTesting(command_line);

}

« no previous file with comments | « no previous file | content/browser/download/save_package.h » ('j') | content/browser/download/save_package.h » ('J')