Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-test
Patch Set: Fixed savable_resources_browsertest.cc to use RenderFrame rather than RenderView. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/savable_resources.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index a323ce16b9ef7d9f0906dbdc4a961df962afee8a..7c418a8dd417d84dba8be0515d056b07d9d0e80d 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1349,8 +1349,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_MediaPlayerActionAt, OnMediaPlayerActionAt)
IPC_MESSAGE_HANDLER(ViewMsg_PluginActionAt, OnPluginActionAt)
IPC_MESSAGE_HANDLER(ViewMsg_SetActive, OnSetActive)
- IPC_MESSAGE_HANDLER(ViewMsg_GetAllSavableResourceLinksForCurrentPage,
- OnGetAllSavableResourceLinksForCurrentPage)
IPC_MESSAGE_HANDLER(
ViewMsg_GetSerializedHtmlDataForCurrentPageWithLocalLinks,
OnGetSerializedHtmlDataForCurrentPageWithLocalLinks)
@@ -2782,46 +2780,6 @@ void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
webview()->performPluginAction(action, location);
}
-void RenderViewImpl::OnGetAllSavableResourceLinksForCurrentPage(
- const GURL& page_url) {
- // Prepare list to storage all savable resource links.
- std::vector<GURL> resources_list;
- std::vector<GURL> referrer_urls_list;
- std::vector<blink::WebReferrerPolicy> referrer_policies_list;
- std::vector<GURL> frames_list;
- SavableResourcesResult result(&resources_list,
- &referrer_urls_list,
- &referrer_policies_list,
- &frames_list);
-
- // webkit/ doesn't know about Referrer.
- if (!GetAllSavableResourceLinksForCurrentPage(
- webview(),
- page_url,
- &result,
- const_cast<const char**>(GetSavableSchemes()))) {
- // If something is wrong when collecting all savable resource links,
- // send empty list to embedder(browser) to tell it failed.
- referrer_urls_list.clear();
- referrer_policies_list.clear();
- resources_list.clear();
- frames_list.clear();
- }
-
- std::vector<Referrer> referrers_list;
- CHECK_EQ(referrer_urls_list.size(), referrer_policies_list.size());
- for (unsigned i = 0; i < referrer_urls_list.size(); ++i) {
- referrers_list.push_back(
- Referrer(referrer_urls_list[i], referrer_policies_list[i]));
- }
-
- // Send result of all savable resource links to embedder.
- Send(new ViewHostMsg_SendCurrentPageAllSavableResourceLinks(routing_id(),
- resources_list,
- referrers_list,
- frames_list));
-}
-
void RenderViewImpl::OnGetSerializedHtmlDataForCurrentPageWithLocalLinks(
const std::vector<GURL>& links,
const std::vector<base::FilePath>& local_paths,
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/savable_resources.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698