Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: content/browser/download/save_package.h

Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-test
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package.h
diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h
index 071a5b7adead60a4eebbad9f4208bd2b957dd38d..59a99c68a0a4c144c17c0762d391c3b48232091a 100644
--- a/content/browser/download/save_package.h
+++ b/content/browser/download/save_package.h
@@ -147,6 +147,8 @@ class CONTENT_EXPORT SavePackage
// WebContentsObserver implementation.
bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message,
+ RenderFrameHost* render_frame_host) override;
// DownloadItem::Observer implementation.
void OnDownloadDestroyed(DownloadItem* download) override;
@@ -177,7 +179,17 @@ class CONTENT_EXPORT SavePackage
// Get all savable resource links from current web page, include main
// frame and sub-frame.
- void GetAllSavableResourceLinksForCurrentPage();
+ void GetSavableResourceLinksForCurrentPage();
+ void GetSavableResourceLinksForFrame(RenderFrameHost*);
+ void OnReceivedNonSavableFrameIndication(RenderFrameHost* render_frame_host);
+ void OnReceivedSavableResourceLinksForFrame(
+ RenderFrameHost* render_frame_host,
+ const std::vector<GURL>& resources_list,
+ const std::vector<Referrer>& referrers_list);
+ void CompleteSavableResourceLinksResponseFromFrame();
+ std::set<GURL> unique_urls_to_save_; // Used to de-dupe urls.
+ int number_of_frames_with_pending_get_savable_resource_links_;
+
// Get html data by serializing all frames of current page with lists
// which contain all resource links that have local copy.
void GetSerializedHtmlDataForCurrentPageWithLocalLinks();
@@ -202,10 +214,6 @@ class CONTENT_EXPORT SavePackage
const base::FilePath& final_name,
SavePageType type,
const SavePackageDownloadCreatedCallback& cb);
- void OnReceivedSavableResourceLinksForCurrentPage(
- const std::vector<GURL>& resources_list,
- const std::vector<Referrer>& referrers_list,
- const std::vector<GURL>& frames_list);
void OnReceivedSerializedHtmlData(const GURL& frame_url,
const std::string& data,

Powered by Google App Engine
This is Rietveld 408576698