content/common/frame_messages.h - Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost.

Side by Side Diff: content/common/frame_messages.h

Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-test

Patch Set: Fixed 2 minor issues caught during a late self-review. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for interacting with frames.	5 // IPC messages for interacting with frames.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "cc/surfaces/surface_id.h"	8 #include "cc/surfaces/surface_id.h"

9 #include "cc/surfaces/surface_sequence.h"	9 #include "cc/surfaces/surface_sequence.h"

10 #include "content/common/content_export.h"	10 #include "content/common/content_export.h"

(...skipping 1004 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1015	1015

1016 // Dispatch a load event for this frame in the iframe element of an	1016 // Dispatch a load event for this frame in the iframe element of an

1017 // out-of-process parent frame.	1017 // out-of-process parent frame.

1018 IPC_MESSAGE_ROUTED0(FrameHostMsg_DispatchLoad)	1018 IPC_MESSAGE_ROUTED0(FrameHostMsg_DispatchLoad)

1019	1019

1020 // Sent to the browser from a frame proxy to post a message to the frame's	1020 // Sent to the browser from a frame proxy to post a message to the frame's

1021 // active renderer.	1021 // active renderer.

1022 IPC_MESSAGE_ROUTED1(FrameHostMsg_RouteMessageEvent,	1022 IPC_MESSAGE_ROUTED1(FrameHostMsg_RouteMessageEvent,

1023 FrameMsg_PostMessage_Params)	1023 FrameMsg_PostMessage_Params)

1024	1024

	1025 // Messages for getting savable resource links from frames into the browser.
	nasko 2015/09/02 23:45:55 nit: s/into/to/ nit: s/into/to/ Łukasz Anforowicz 2015/09/03 16:59:57 N/A after moving the messages (and having a separa Show quoted text On 2015/09/02 23:45:55, nasko (slow to review) wrote: > nit: s/into/to/ N/A after moving the messages (and having a separate comment for each).
	1026 IPC_MESSAGE_ROUTED0(FrameMsg_GetSavableResourceLinks)
	nasko 2015/09/02 23:45:55 Please keep FrameMsg messages (which means browser Please keep FrameMsg messages (which means browser->renderer) with the rest of the FrameMsg ones. The file is split in two parts and are grouped by direction of the message. FrameHostMsg are renderer->browser. Łukasz Anforowicz 2015/09/03 16:59:57 Done. Show quoted text On 2015/09/02 23:45:55, nasko (slow to review) wrote: > Please keep FrameMsg messages (which means browser->renderer) with the rest of > the FrameMsg ones. The file is split in two parts and are grouped by direction > of the message. FrameHostMsg are renderer->browser. Done.
	1027 IPC_MESSAGE_ROUTED0(FrameHostMsg_NonSavableResponse)
	nasko 2015/09/02 23:45:55 Put a comment explaining what this message is abou Put a comment explaining what this message is about. Same for the one below. Łukasz Anforowicz 2015/09/03 16:59:57 Done. Show quoted text On 2015/09/02 23:45:55, nasko (slow to review) wrote: > Put a comment explaining what this message is about. Same for the one below. Done.
	1028 IPC_MESSAGE_ROUTED2(FrameHostMsg_SavableResourceLinksResponse,

	1029 std::vector<GURL> /* savable resource links */,

	1030 std::vector<content::Referrer> /* referrers */)

	1031

1025 #if defined(OS_MACOSX) \|\| defined(OS_ANDROID)	1032 #if defined(OS_MACOSX) \|\| defined(OS_ANDROID)

1026	1033

1027 // Message to show/hide a popup menu using native controls.	1034 // Message to show/hide a popup menu using native controls.

1028 IPC_MESSAGE_ROUTED1(FrameHostMsg_ShowPopup,	1035 IPC_MESSAGE_ROUTED1(FrameHostMsg_ShowPopup,

1029 FrameHostMsg_ShowPopup_Params)	1036 FrameHostMsg_ShowPopup_Params)

1030 IPC_MESSAGE_ROUTED0(FrameHostMsg_HidePopup)	1037 IPC_MESSAGE_ROUTED0(FrameHostMsg_HidePopup)

1031	1038

1032 #endif	1039 #endif

OLD	NEW

« content/browser/download/save_package.cc ('K') | « content/browser/download/save_package.cc ('k') | content/common/view_messages.h » ('j') | content/renderer/render_frame_impl.cc » ('J')