Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1308113008: OOPIFs: Transitioning Get/Send...SavableResourceLinks away from RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-test
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 SavePageSitePerProcessBrowserTest() {} 778 SavePageSitePerProcessBrowserTest() {}
779 779
780 protected: 780 protected:
781 typedef SavePageBrowserTest BaseClass; 781 typedef SavePageBrowserTest BaseClass;
782 782
783 void SetUpCommandLine(base::CommandLine* command_line) override { 783 void SetUpCommandLine(base::CommandLine* command_line) override {
784 BaseClass::SetUpCommandLine(command_line); 784 BaseClass::SetUpCommandLine(command_line);
785 785
786 // TODO(lukasza): Enable --site-per-process once crbug.com/526786 is fixed. 786 // TODO(lukasza): Enable --site-per-process once crbug.com/526786 is fixed.
787 // (currently, when the line below is uncommented out, the test crashes 787 // (currently, when the line below is uncommented out, the test crashes
788 // under RenderViewImpl::OnGetAllSavableResourceLinksForCurrentPage). 788 // under RenderViewImpl::OnGetSerializedHtmlDataForCu...PageWithLocalLinks).
789 // content::IsolateAllSitesForTesting(command_line); 789 // content::IsolateAllSitesForTesting(command_line);
790 } 790 }
791 791
792 void SetUpOnMainThread() override { 792 void SetUpOnMainThread() override {
793 BaseClass::SetUpOnMainThread(); 793 BaseClass::SetUpOnMainThread();
794 794
795 host_resolver()->AddRule("*", "127.0.0.1"); 795 host_resolver()->AddRule("*", "127.0.0.1");
796 ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady()); 796 ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
797 content::SetupCrossSiteRedirector(embedded_test_server()); 797 content::SetupCrossSiteRedirector(embedded_test_server());
798 } 798 }
(...skipping 28 matching lines...) Expand all
827 << " non-empty?"; 827 << " non-empty?";
828 } 828 }
829 // Main purpose of this test is to verify that product code doesn't assume 829 // Main purpose of this test is to verify that product code doesn't assume
830 // that all frames live in the same process (which caused a crash - 830 // that all frames live in the same process (which caused a crash -
831 // crbug.com/526786). We only do rudimentary check of file size here and we 831 // crbug.com/526786). We only do rudimentary check of file size here and we
832 // do no detailed verification of file content, because this should already be 832 // do no detailed verification of file content, because this should already be
833 // covered by other tests above. 833 // covered by other tests above.
834 } 834 }
835 835
836 } // namespace 836 } // namespace
OLDNEW
« no previous file with comments | « no previous file | content/browser/download/save_package.h » ('j') | content/browser/download/save_package.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698