Fix javac command never caching input .md5s

build/android/gyp/util/build_utils.py

Index: build/android/gyp/util/build_utils.py
diff --git a/build/android/gyp/util/build_utils.py b/build/android/gyp/util/build_utils.py
index 65b1a643c26a2ca920ff176af40bfcad85057f3d..55bfb1bc77aed567f3c2dc907b4a7db5e7dc7917 100644
--- a/build/android/gyp/util/build_utils.py
+++ b/build/android/gyp/util/build_utils.py
@@ -235,20 +235,19 @@ def ZipDir(output, base_dir):
         outfile.write(path, archive_path)
 
 
+def MatchesGlob(path, filters):
+  """Returns whether the given path matches any of the given glob patterns."""
+  return filters and any(fnmatch.fnmatch(path, f) for f in filters)

[jbudorick, 2015/09/01 16:28:09]

I don't think this is the same as Allow, which would return True if
exclude_patterns was None. Is that intentional? (It doesn't look like it, but
I'm not sure.) If not, this should be

  return not filters or any(...)

[agrieve, 2015/09/01 16:58:18]

It is intentionally different, in that it simplifies the usages a bit. It's
still the case in MergeZips that no filters results in the action happening.

+
+
 def MergeZips(output, inputs, exclude_patterns=None):
   added_names = set()
-  def Allow(name):
-    if exclude_patterns is not None:
-      for p in exclude_patterns:
-        if fnmatch.fnmatch(name, p):
-          return False
-    return True
 
   with zipfile.ZipFile(output, 'w') as out_zip:
     for in_file in inputs:
       with zipfile.ZipFile(in_file, 'r') as in_zip:
         for name in in_zip.namelist():
-          if name not in added_names and Allow(name):
+          if not (name in added_names or MatchesGlob(name, exclude_patterns)):
             out_zip.writestr(name, in_zip.read(name))
             added_names.add(name)