runtime/vm/parser.h - Issue 1308073005: Introduce per-isolate cache for compile time constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.h

Issue 1308073005: Introduce per-isolate cache for compile time constants (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Addressing review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser.h

diff --git a/runtime/vm/parser.h b/runtime/vm/parser.h

index 4524b7a07a9683423844280e4d4352b9e545744d..d9d24c92cacb76058529bdb622cc5bfed4dbbef8 100644

--- a/runtime/vm/parser.h

+++ b/runtime/vm/parser.h

@@ -817,6 +817,8 @@ class Parser : public ValueObject {

ArgumentListNode* arguments);

RawInstance* TryCanonicalize(const Instance& instance, intptr_t token_pos);

+ void CacheConstantValue(intptr_t token_pos, const Instance& value);

+ bool GetCachedConstant(intptr_t token_pos, Instance* value);

Thread* thread() const { return thread_; }

Isolate* isolate() const { return isolate_; }

« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »