runtime/vm/object.h - Issue 1308073005: Introduce per-isolate cache for compile time constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 1308073005: Introduce per-isolate cache for compile time constants (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Addressing review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h

index 845d9da9481c3347b311f60b4487788dd9bb9443..1b36099128754bf4c638b0766068a6f1d88ded3e 100644

--- a/runtime/vm/object.h

+++ b/runtime/vm/object.h

@@ -5940,7 +5940,7 @@ class String : public Instance {

static intptr_t hash_offset() { return OFFSET_OF(RawString, hash_); }

static intptr_t Hash(const String& str, intptr_t begin_index, intptr_t len);

- static intptr_t HashLatin1(const uint8_t* characters, intptr_t len);

+ static intptr_t Hash(const char* characters, intptr_t len);

static intptr_t Hash(const uint16_t* characters, intptr_t len);

static intptr_t Hash(const int32_t* characters, intptr_t len);

static intptr_t HashRawSymbol(const RawString* symbol) {

« no previous file with comments | « runtime/vm/compiler_stats.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »