Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1308073004: Revert of Apply the bot config api based on the command line arguments. (Closed)

Created:
5 years, 4 months ago by Geoff Lang
Modified:
5 years, 4 months ago
Reviewers:
Zhenyao Mo, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply the bot config api based on the command line arguments. (patchset #2 id:20001 of https://codereview.chromium.org/1277253002/ ) Reason for revert: Compile failure on linux. Original issue's description: > Apply the bot config api based on the command line arguments. > > Allows for expectations based on the ANGLE renderer. > > BUG=490149 > > Committed: https://crrev.com/68c9284f34a247d12327d188d75b81b1b4dd3791 > Cr-Commit-Position: refs/heads/master@{#345331} TBR=sievers@chromium.org,zmo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490149 Committed: https://crrev.com/8ca49e574c877eed49b044d587fba474a22ae5cd Cr-Commit-Position: refs/heads/master@{#345337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M gpu/gles2_conform_support/gles2_conform_test.cc View 2 chunks +1 line, -30 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test_expectations.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Geoff Lang
Created Revert of Apply the bot config api based on the command line arguments.
5 years, 4 months ago (2015-08-25 15:43:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308073004/1
5 years, 4 months ago (2015-08-25 15:43:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 15:44:05 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 15:44:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ca49e574c877eed49b044d587fba474a22ae5cd
Cr-Commit-Position: refs/heads/master@{#345337}

Powered by Google App Engine
This is Rietveld 408576698