Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 1308063008: Introduce ComposedTreeTraversal::previousPostOrder() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce ComposedTreeTraversal::previousPostOrder() This patch introduces |ComposedTreeTraversal::previousPostOrder()| which is composed tree version of |NodeTraversal::previousPostOrder()| as a preparation of implementing composed tree version of |startOfParagraph()|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201965

Patch Set 1 : 2015-09-09T16:39:28 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M Source/core/dom/shadow/ComposedTreeTraversal.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeTraversal.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeTraversalTest.cpp View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-09 08:04:12 UTC) #2
tkent
rs lgtm. I confirmed the implementation was equivalent to NodeTraversal::previousPostOrder.
5 years, 3 months ago (2015-09-09 08:38:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308063008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308063008/1
5 years, 3 months ago (2015-09-09 08:49:01 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:56:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201965

Powered by Google App Engine
This is Rietveld 408576698