Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/web_input_event_aura.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/web_input_event_aura_unittest.cc
diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc
index 288f48dc0c13489f791a028018174adcbeec1841..42c6a978f6bf4766be10e92da5db83f680f2af9d 100644
--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc
+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc
@@ -115,8 +115,7 @@ TEST(WebInputEventAuraTest, MAYBE_TestMakeWebKeyboardEventWindowsKeyCode) {
ui::KeycodeConverter::DomCodeToNativeKeycode(ui::DomCode::CONTROL_LEFT);
ui::KeyEvent event(xev);
blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
- // ui::VKEY_LCONTROL, instead of ui::VKEY_CONTROL, should be filled.
- EXPECT_EQ(ui::VKEY_LCONTROL, webkit_event.windowsKeyCode);
+ EXPECT_EQ(ui::VKEY_CONTROL, webkit_event.windowsKeyCode);
}
{
// Press right Ctrl.
@@ -126,8 +125,7 @@ TEST(WebInputEventAuraTest, MAYBE_TestMakeWebKeyboardEventWindowsKeyCode) {
ui::DomCode::CONTROL_RIGHT);
ui::KeyEvent event(xev);
blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
- // ui::VKEY_RCONTROL, instead of ui::VKEY_CONTROL, should be filled.
- EXPECT_EQ(ui::VKEY_RCONTROL, webkit_event.windowsKeyCode);
+ EXPECT_EQ(ui::VKEY_CONTROL, webkit_event.windowsKeyCode);
}
#elif defined(OS_WIN)
// TODO(yusukes): Add tests for win_aura once keyboardEvent() in
@@ -141,8 +139,7 @@ TEST(WebInputEventAuraTest, MAYBE_TestMakeWebKeyboardEventWindowsKeyCode) {
ui::DomCode::CONTROL_LEFT, ui::EF_CONTROL_DOWN,
ui::DomKey::CONTROL, ui::EventTimeForNow());
blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
- // ui::VKEY_LCONTROL, instead of ui::VKEY_CONTROL, should be filled.
- EXPECT_EQ(ui::VKEY_LCONTROL, webkit_event.windowsKeyCode);
+ EXPECT_EQ(ui::VKEY_CONTROL, webkit_event.windowsKeyCode);
}
{
// Press right Ctrl.
@@ -150,8 +147,7 @@ TEST(WebInputEventAuraTest, MAYBE_TestMakeWebKeyboardEventWindowsKeyCode) {
ui::DomCode::CONTROL_RIGHT, ui::EF_CONTROL_DOWN,
ui::DomKey::CONTROL, ui::EventTimeForNow());
blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(event);
- // ui::VKEY_RCONTROL, instead of ui::VKEY_CONTROL, should be filled.
- EXPECT_EQ(ui::VKEY_RCONTROL, webkit_event.windowsKeyCode);
+ EXPECT_EQ(ui::VKEY_CONTROL, webkit_event.windowsKeyCode);
}
}
« no previous file with comments | « content/browser/renderer_host/web_input_event_aura.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698