content/browser/renderer_host/input/web_input_event_builders_win.cc - Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_win.cc

Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/web_input_event_builders_android.cc ('k') | content/browser/renderer_host/input/web_input_event_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_builders_win.cc

diff --git a/content/browser/renderer_host/input/web_input_event_builders_win.cc b/content/browser/renderer_host/input/web_input_event_builders_win.cc

index f3eec13ee9c8730c3a07d651ddfb308d2581d91c..b029701e4fa4438f59c4f7e9661842726c1a08f9 100644

--- a/content/browser/renderer_host/input/web_input_event_builders_win.cc

+++ b/content/browser/renderer_host/input/web_input_event_builders_win.cc

@@ -69,11 +69,8 @@ WebKeyboardEvent WebKeyboardEventBuilder::Build(HWND hwnd,

result.text[0] = result.windowsKeyCode;

result.unmodifiedText[0] = result.windowsKeyCode;

}

- if (result.type != WebInputEvent::Char) {

- UpdateWindowsKeyCodeAndKeyIdentifier(

- &result,

- static_cast<ui::KeyboardCode>(result.windowsKeyCode));

- }

+ if (result.type != WebInputEvent::Char)

+ result.setKeyIdentifierFromWindowsKeyCode();

if (::GetKeyState(VK_SHIFT) & 0x8000)

result.modifiers |= WebInputEvent::ShiftKey;