content/browser/renderer_host/web_input_event_aura.cc - Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/web_input_event_aura.cc

Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/web_input_event_builders_win.cc ('K') | « content/browser/renderer_host/input/web_input_event_util_posix.cc ('k') | content/content_browser.gypi » ('j') | ui/events/keycodes/keyboard_code_conversion_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/web_input_event_aura.cc

diff --git a/content/browser/renderer_host/web_input_event_aura.cc b/content/browser/renderer_host/web_input_event_aura.cc

index bbad8c7729de5201641ca854491549d3ff0f6816..57c13838aea8745cf51397ef5e170bc15ae1e10d 100644

--- a/content/browser/renderer_host/web_input_event_aura.cc

+++ b/content/browser/renderer_host/web_input_event_aura.cc

@@ -84,7 +84,7 @@ blink::WebKeyboardEvent MakeWebKeyboardEventFromAuraEvent(

if (webkit_event.modifiers & blink::WebInputEvent::AltKey)

webkit_event.isSystemKey = true;

- webkit_event.windowsKeyCode = event.GetLocatedWindowsKeyboardCode();

+ webkit_event.windowsKeyCode = event.key_code();

kpschoedel 2015/09/01 20:51:22 I suspect mojo/converters/input_events/input_event

dtapuska 2015/09/01 20:54:11 ui::Event modifiers didn't seem to be serialized a

kpschoedel 2015/09/02 15:05:45 I think the intent is for the ui::Event → input_ev

webkit_event.nativeKeyCode =

ui::KeycodeConverter::DomCodeToNativeKeycode(event.code());

webkit_event.domCode = static_cast<int>(event.code());