ui/events/keycodes/keyboard_code_conversion_android.h - Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/keycodes/keyboard_code_conversion_android.h

Issue 1308063007: Generate non-located windowsKeyCode for the WebInputEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against dependent change Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_ANDROID_H_	5 #ifndef UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_ANDROID_H_

6 #define UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_ANDROID_H_	6 #define UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_ANDROID_H_

7	7

8 #include "ui/events/events_base_export.h"	8 #include "ui/events/events_base_export.h"

9 #include "ui/events/keycodes/keyboard_codes_posix.h"	9 #include "ui/events/keycodes/keyboard_codes_posix.h"

10	10

11 namespace ui {	11 namespace ui {
	Wez 2015/09/09 06:06:11 Looks like this and the cc file can go away entire Looks like this and the cc file can go away entirely? dtapuska 2015/09/09 18:45:49 See comment on the left side of this file.. I stat Show quoted text On 2015/09/09 06:06:11, Wez wrote: > Looks like this and the cc file can go away entirely? See comment on the left side of this file.. I stated that I'd add to this file in the next change.
12	12
dtapuska 2015/09/08 17:21:38 Yes this file is empty; and in context of this cha Yes this file is empty; and in context of this change could be removed. But when I add the DomKey support for Android; it adds a function in this file.
13 EVENTS_BASE_EXPORT KeyboardCode KeyboardCodeFromAndroidKeyCode(int keycode);

14

15 } // namespace ui	13 } // namespace ui

16	14

17 #endif // UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_ANDROID_H_	15 #endif // UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_ANDROID_H_

OLD	NEW