Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1308053003: Replace pinch scrollbars with regular scrollbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/FrameView.cpp ('K') | « Source/platform/scroll/ScrollableArea.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 61f5e826a1e251ed92d4b2fe13f6a26e11150824..8bdacadc8d96bbdc1786767a2db00da5ffdb583a 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -2417,12 +2417,7 @@ TEST_P(ParameterizedWebFrameTest, CanOverrideScaleLimits)
EXPECT_EQ(2.0f, webViewHelper.webViewImpl()->maximumPageScaleFactor());
}
-// Android doesn't have scrollbars on the main FrameView
-#if OS(ANDROID)
-TEST_F(WebFrameTest, DISABLED_updateOverlayScrollbarLayers)
-#else
TEST_F(WebFrameTest, updateOverlayScrollbarLayers)
-#endif
{
UseMockScrollbarSettings mockScrollbarSettings;
@@ -2441,11 +2436,6 @@ TEST_F(WebFrameTest, updateOverlayScrollbarLayers)
FrameView* view = webViewHelper.webViewImpl()->mainFrameImpl()->frameView();
EXPECT_TRUE(view->layoutView()->compositor()->layerForHorizontalScrollbar());
EXPECT_TRUE(view->layoutView()->compositor()->layerForVerticalScrollbar());
-
- webViewHelper.webView()->resize(WebSize(viewWidth * 10, viewHeight * 10));
- webViewHelper.webView()->layout();
- EXPECT_FALSE(view->layoutView()->compositor()->layerForHorizontalScrollbar());
- EXPECT_FALSE(view->layoutView()->compositor()->layerForVerticalScrollbar());
}
void setScaleAndScrollAndLayout(WebViewImpl* webView, WebPoint scroll, float scale)
« Source/core/frame/FrameView.cpp ('K') | « Source/platform/scroll/ScrollableArea.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698