Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308043003: Add a bunch more tests for deferred commit handling. (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
Reviewers:
pdr., dglazkov, dcheng
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a bunch more tests for deferred commit handling. This adds tests for the various conditions of when to resume commits. BUG=521692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201450

Patch Set 1 #

Patch Set 2 : typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -17 lines) Patch
M Source/web/tests/DocumentLoadingRenderingTest.cpp View 1 1 chunk +116 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308043003/1
5 years, 3 months ago (2015-08-28 23:05:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308043003/20001
5 years, 3 months ago (2015-08-28 23:16:56 UTC) #5
esprehn
5 years, 3 months ago (2015-08-29 00:02:18 UTC) #7
esprehn
5 years, 3 months ago (2015-08-29 00:02:46 UTC) #9
dglazkov
lgtm
5 years, 3 months ago (2015-08-29 00:03:22 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-29 00:03:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308043003/20001
5 years, 3 months ago (2015-08-29 06:16:40 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 06:20:51 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201450

Powered by Google App Engine
This is Rietveld 408576698