Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

Issue 1308033003: Use enclosingIntRect instead of pixelSnappedIntRect to expand invalidation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: another virtual/spv2/ test appears Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutView.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 2021 matching lines...) Expand 10 before | Expand all | Expand 10 after
2032 IntRect r; 2032 IntRect r;
2033 PaintInvalidationReason invalidationReason; 2033 PaintInvalidationReason invalidationReason;
2034 }; 2034 };
2035 2035
2036 // r is in the coordinate space of the layer's layout object 2036 // r is in the coordinate space of the layer's layout object
2037 void CompositedDeprecatedPaintLayerMapping::setContentsNeedDisplayInRect(const L ayoutRect& r, PaintInvalidationReason invalidationReason) 2037 void CompositedDeprecatedPaintLayerMapping::setContentsNeedDisplayInRect(const L ayoutRect& r, PaintInvalidationReason invalidationReason)
2038 { 2038 {
2039 // FIXME: need to split out paint invalidations for the background. 2039 // FIXME: need to split out paint invalidations for the background.
2040 // FIXME: need to distinguish invalidations for different layers (e.g. the m ain layer and scrolling layer). crbug.com/416535. 2040 // FIXME: need to distinguish invalidations for different layers (e.g. the m ain layer and scrolling layer). crbug.com/416535.
2041 SetContentsNeedsDisplayInRectFunctor functor = { 2041 SetContentsNeedsDisplayInRectFunctor functor = {
2042 pixelSnappedIntRect(r.location() + m_owningLayer.subpixelAccumulation(), r.size()), 2042 enclosingIntRect(LayoutRect(r.location() + m_owningLayer.subpixelAccumul ation(), r.size())),
2043 invalidationReason 2043 invalidationReason
2044 }; 2044 };
2045 ApplyToGraphicsLayers(this, functor, ApplyToContentLayers); 2045 ApplyToGraphicsLayers(this, functor, ApplyToContentLayers);
2046 } 2046 }
2047 2047
2048 void CompositedDeprecatedPaintLayerMapping::invalidateDisplayItemClient(const Di splayItemClientWrapper& displayItemClient) 2048 void CompositedDeprecatedPaintLayerMapping::invalidateDisplayItemClient(const Di splayItemClientWrapper& displayItemClient)
2049 { 2049 {
2050 ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled()); 2050 ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled());
2051 2051
2052 // FIXME: need to split out paint invalidations for the background. 2052 // FIXME: need to split out paint invalidations for the background.
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
2397 } else if (graphicsLayer == m_scrollingBlockSelectionLayer.get()) { 2397 } else if (graphicsLayer == m_scrollingBlockSelectionLayer.get()) {
2398 name = "Scrolling Block Selection Layer"; 2398 name = "Scrolling Block Selection Layer";
2399 } else { 2399 } else {
2400 ASSERT_NOT_REACHED(); 2400 ASSERT_NOT_REACHED();
2401 } 2401 }
2402 2402
2403 return name; 2403 return name;
2404 } 2404 }
2405 2405
2406 } // namespace blink 2406 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698