Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Side by Side Diff: Source/core/layout/LayoutBoxModelObject.cpp

Issue 1308033003: Use enclosingIntRect instead of pixelSnappedIntRect to expand invalidation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: another virtual/spv2/ test appears Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 { 352 {
353 // https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here, 353 // https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here,
354 // so assert but check that the layer is composited. 354 // so assert but check that the layer is composited.
355 ASSERT(compositingState() != NotComposited); 355 ASSERT(compositingState() != NotComposited);
356 356
357 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic. 357 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic.
358 if (layer()->groupedMapping()) { 358 if (layer()->groupedMapping()) {
359 LayoutRect paintInvalidationRect = r; 359 LayoutRect paintInvalidationRect = r;
360 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) { 360 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) {
361 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 361 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
362 squashingLayer->setNeedsDisplayInRect(pixelSnappedIntRect(paintInval idationRect), invalidationReason); 362 squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintInvalida tionRect), invalidationReason);
363 } 363 }
364 } else { 364 } else {
365 layer()->compositedDeprecatedPaintLayerMapping()->setContentsNeedDisplay InRect(r, invalidationReason); 365 layer()->compositedDeprecatedPaintLayerMapping()->setContentsNeedDisplay InRect(r, invalidationReason);
366 } 366 }
367 } 367 }
368 368
369 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClientWrapper& displayItemClient) const 369 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClientWrapper& displayItemClient) const
370 { 370 {
371 ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled()); 371 ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled());
372 372
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 if (rootElementStyle->hasBackground()) 1017 if (rootElementStyle->hasBackground())
1018 return false; 1018 return false;
1019 1019
1020 if (node() != document().firstBodyElement()) 1020 if (node() != document().firstBodyElement())
1021 return false; 1021 return false;
1022 1022
1023 return true; 1023 return true;
1024 } 1024 }
1025 1025
1026 } // namespace blink 1026 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/fast/repaint/subpixel-shadow-included-in-invalidation-expected.txt ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698