Fix UMA recoding code for FileBrowser.ViewingFileType.

chrome/browser/resources/file_manager/foreground/js/file_tasks.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * This object encapsulates everything related to tasks execution.
  *
  * @param {FileManager} fileManager FileManager instance.
@@ skipping 115 matching lines @@
 
 /**
  * The list of known extensions to record UMA.
  * Note: Because the data is recorded by the index, so new item shouldn't be
  * inserted.
  *
  * @const
  * @type {Array.<string>}
  * @private
  */
-FileTasks.knownExtensions_ = [
+FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_ = Object.freeze([
   'other', '.3ga', '.3gp', '.aac', '.alac', '.asf', '.avi', '.bmp', '.csv',
-  '.doc', '.docx', '.flac', '.gif', '.ico', '.jpeg', '.jpg', '.log', '.m3u',
-  '.m3u8', '.m4a', '.m4v', '.mid', '.mkv', '.mov', '.mp3', '.mp4', '.mpg',
-  '.odf', '.odp', '.ods', '.odt', '.oga', '.ogg', '.ogv', '.pdf', '.png',
-  '.ppt', '.pptx', '.ra', '.ram', '.rar', '.rm', '.rtf', '.wav', '.webm',
-  '.webp', '.wma', '.wmv', '.xls', '.xlsx',
-];
+  '.doc', '.docx', '.flac', '.gif', '.jpeg', '.jpg', '.log', '.m3u', '.m3u8',
+  '.m4a', '.m4v', '.mid', '.mkv', '.mov', '.mp3', '.mp4', '.mpg', '.odf',
+  '.odp', '.ods', '.odt', '.oga', '.ogg', '.ogv', '.pdf', '.png', '.ppt',
+  '.pptx', '.ra', '.ram', '.rar', '.rm', '.rtf', '.wav', '.webm', '.webp',
+  '.wma', '.wmv', '.xls', '.xlsx',
+]);
 
 /**
  * The list of excutable file extensions.
  *
  * @const
  * @type {Array.<string>}
  */
 FileTasks.EXECUTABLE_EXTENSIONS = Object.freeze([
   '.exe', '.lnk', '.deb', '.dmg', '.jar', '.msi',
 ]);
@@ skipping 11 matching lines @@
 /**
  * Records trial of opening file grouped by extensions.
  *
  * @param {Array.<Entry>} entries The entries to be opened.
  * @private
  */
 FileTasks.recordViewingFileTypeUMA_ = function(entries) {
   for (var i = 0; i < entries.length; i++) {
     var entry = entries[i];
     var extension = FileType.getExtension(entry).toLowerCase();
-    if (FileTasks.knownExtensions_.indexOf(extension) < 0) {
+    if (FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_.indexOf(extension) < 0) {
       extension = 'other';
     }
     metrics.recordEnum(
-        'ViewingFileType', extension, FileTasks.knownExtensions_);
+        'ViewingFileType', extension, FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_);
   }
 };
 
 /**
  * Returns true if the taskId is for an internal task.
  *
  * @param {string} taskId Task identifier.
  * @return {boolean} True if the task ID is for an internal task.
  * @private
  */
@@ skipping 667 matching lines @@
       items, defaultIdx,
       function(item) {
         onSuccess(item.task);
       });
 };
 
 FileTasks.decorate('display');
 FileTasks.decorate('updateMenuItem');
 FileTasks.decorate('execute');
 FileTasks.decorate('executeDefault');