Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 130803008: Fix UMA recoding code for FileBrowser.ViewingFileType. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix UMA recoding code for FileBrowser.ViewingFileType. In r239446 I carelessly inserted '.ico' to the array but I should have not. The array is for indexing enum of metric stat that need to match with remote side config. Let me just revert the addition. I think we are not so eager to count '.ico''s popularity. BUG=339023 R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/file_tasks.js View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinaba
6 years, 10 months ago (2014-01-29 08:39:06 UTC) #1
hirono
lgtm!
6 years, 10 months ago (2014-01-29 10:33:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/130803008/1
6 years, 10 months ago (2014-01-29 10:56:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=43129
6 years, 10 months ago (2014-01-30 01:49:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/130803008/1
6 years, 10 months ago (2014-01-30 03:05:27 UTC) #5
kinaba
Committed patchset #1 manually as r247826 (presubmit successful).
6 years, 10 months ago (2014-01-30 04:02:38 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 04:03:13 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698