Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1308023005: Re-enable memcmp interceptor for TSan. (Closed)

Created:
5 years, 3 months ago by eugenis
Modified:
5 years, 3 months ago
Reviewers:
kcc1, kcc2, hans
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable memcmp interceptor for TSan. But make it not strict. This is roughly the same behavior as we had before the clang roll and the workaround in crbug.com/523384. BUG=523384 Committed: https://crrev.com/5ae1e02429f0aa082ec2e2b524c38031087c47bc Cr-Commit-Position: refs/heads/master@{#345991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/sanitizers/sanitizer_options.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
eugenis
5 years, 3 months ago (2015-08-27 00:39:58 UTC) #2
kcc1
lgtm LGTM
5 years, 3 months ago (2015-08-27 16:13:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308023005/1
5 years, 3 months ago (2015-08-27 16:13:30 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-27 16:13:32 UTC) #8
eugenis
5 years, 3 months ago (2015-08-27 18:39:07 UTC) #10
hans
cc thakis fyi lgtm
5 years, 3 months ago (2015-08-27 20:24:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308023005/1
5 years, 3 months ago (2015-08-27 20:36:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 21:18:26 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 21:19:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ae1e02429f0aa082ec2e2b524c38031087c47bc
Cr-Commit-Position: refs/heads/master@{#345991}

Powered by Google App Engine
This is Rietveld 408576698