Issue 1308023003: [sql] Blink-side changes to allow sqlite to be a shlib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1308023003: [sql] Blink-side changes to allow sqlite to be a shlib. (Closed)

Created:
5 years, 4 months ago by Scott Hess - ex-Googler

Modified:
5 years, 3 months ago

Reviewers:

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[sql] Blink-side changes to allow sqlite to be a shlib. This CL NOT FOR CHECKIN. Browser-side changes at https://codereview.chromium.org/1312463002 Under the component build, sqlite.gyp builds a static library which is linked independently into shlibs and executables. This means that sql_unittests and the sql shlib will see different sqlite3 functions, which see different globals, and hilarity ensues. BUG=489444

Patch Set 1 #

Patch Set 2 : Also gn build. #

Patch Set 3 : Doc the #define #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
M	Source/core/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/core.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/modules/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/modules.gyp	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp	View	1 2	2 chunks	+3 lines, -9 lines	0 comments	Download
M	Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp	View	1 2	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Doc the #define

Expand Messages | Collapse Messages