extensions/renderer/event_bindings.cc - Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/event_bindings.cc

Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made conversions static members. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/event_bindings.cc

diff --git a/extensions/renderer/event_bindings.cc b/extensions/renderer/event_bindings.cc

index 229a1c89b6f99cab1b178ec4b3fb791ab047d015..82e63471b5cddf9c765474a3c011d4ef5ee55163 100644

--- a/extensions/renderer/event_bindings.cc

+++ b/extensions/renderer/event_bindings.cc

@@ -265,7 +265,7 @@ void EventBindings::AttachFilteredEvent(

args.GetReturnValue().Set(static_cast<int32_t>(-1));

return;

}

- filter.reset(static_cast<base::DictionaryValue*>(filter_value.release()));

+ filter = base::DictionaryValue::From(filter_value.Pass());

}

// Hold onto a weak reference to |filter| so that it can be used after passing

« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | no next file with comments »