extensions/common/features/json_feature_provider_source.cc - Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/json_feature_provider_source.cc

Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made conversions static members. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/features/json_feature_provider_source.cc

diff --git a/extensions/common/features/json_feature_provider_source.cc b/extensions/common/features/json_feature_provider_source.cc

index 5b9ee168378f0ee4b719455f8337425c42e39591..5f9dcb54f9f2f4120417f47d074bba4276fa772b 100644

--- a/extensions/common/features/json_feature_provider_source.cc

+++ b/extensions/common/features/json_feature_provider_source.cc

@@ -30,7 +30,7 @@ void JSONFeatureProviderSource::LoadJSON(int resource_id) {

scoped_ptr<base::DictionaryValue> value_as_dict;

if (value) {

CHECK(value->IsType(base::Value::TYPE_DICTIONARY)) << name_;

- value_as_dict.reset(static_cast<base::DictionaryValue*>(value.release()));

+ value_as_dict = base::DictionaryValue::From(value.Pass());

} else {

// There was some error loading the features file.

// http://crbug.com/176381

« no previous file with comments | « extensions/common/extension_api.cc ('k') | extensions/common/file_util.h » ('j') | no next file with comments »