extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc - Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc

Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made conversions static members. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc

diff --git a/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc b/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc

index d6db1620c23a8256e26d319180e75b40f42be76d..b5bbd0c473b76703896767e4c494d71412f60103 100644

--- a/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc

+++ b/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc

@@ -63,8 +63,8 @@ IN_PROC_BROWSER_TEST_F(SocketsTcpApiTest, SocketsTcpCreateGood) {

socket_create_function.get(), "[]", browser_context()));

ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());

- base::DictionaryValue* value =

- static_cast<base::DictionaryValue*>(result.get());

+ scoped_ptr<base::DictionaryValue> value =

+ base::DictionaryValue::From(result.Pass());

int socketId = -1;

EXPECT_TRUE(value->GetInteger("socketId", &socketId));

ASSERT_TRUE(socketId > 0);

« no previous file with comments | « base/values.cc ('k') | extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc » ('j') | no next file with comments »