Add scoped_ptr-safe base::Value to Dictionary/List conversion functions.

extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/guest_view/guest_view_internal_custom_bindings.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 133 matching lines @@
   if (!guest_view_container)
     return;
 
   int guest_instance_id = args[1]->Int32Value();
 
   scoped_ptr<base::DictionaryValue> params;
   {
     scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
     scoped_ptr<base::Value> params_as_value(
         converter->FromV8Value(args[2], context()->v8_context()));
-    CHECK(params_as_value->IsType(base::Value::TYPE_DICTIONARY));
-    params.reset(
-        static_cast<base::DictionaryValue*>(params_as_value.release()));
+    params = base::DictionaryValue::From(params_as_value.Pass());
+    CHECK(params);
   }
 
   // Add flag to |params| to indicate that the element size is specified in
   // logical units.
   params->SetBoolean(guest_view::kElementSizeIsLogical, true);
 
   linked_ptr<guest_view::GuestViewRequest> request(
       new guest_view::GuestViewAttachRequest(
           guest_view_container, guest_instance_id, params.Pass(),
           args.Length() == 4 ? args[3].As<v8::Function>()
@@ skipping 52 matching lines @@
         args[num_required_params]->IsFunction());
 
   int element_instance_id = args[0]->Int32Value();
   int guest_instance_id = args[1]->Int32Value();
 
   scoped_ptr<base::DictionaryValue> params;
   {
     scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
     scoped_ptr<base::Value> params_as_value(
         converter->FromV8Value(args[2], context()->v8_context()));
-    CHECK(params_as_value->IsType(base::Value::TYPE_DICTIONARY));
-    params.reset(
-        static_cast<base::DictionaryValue*>(params_as_value.release()));
+    params = base::DictionaryValue::From(params_as_value.Pass());
+    CHECK(params);
   }
 
   // Add flag to |params| to indicate that the element size is specified in
   // logical units.
   params->SetBoolean(guest_view::kElementSizeIsLogical, true);
 
   content::RenderFrame* render_frame = GetRenderFrame(args[3]);
   blink::WebLocalFrame* frame = render_frame->GetWebFrame();
 
   // Parent must exist.
@@ skipping 180 matching lines @@
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // Gesture is required to request fullscreen.
   blink::WebScopedUserGesture user_gesture;
   CHECK_EQ(args.Length(), 1);
   CHECK(args[0]->IsFunction());
   v8::Local<v8::Value> no_args;
   context()->CallFunction(v8::Local<v8::Function>::Cast(args[0]), 0, &no_args);
 }
 
 }  // namespace extensions